Revisions for whups/ticket/update.php

Limit Robert's copyright to the years of his contributions. We should really find him.

Tags: WHUPS_1_0, WHUPS_1_0_RC2, WHUPS_1_0_RC1

There's no reason why guests shouldn't be allowed to update tickets if they
have the permission to do so.

Deal with queue vs. admin permissions more consistently.

[cjh] Use pretty URLs if Horde is configured for them (Request #5922).

Standardize on the same ctor signature for both ticket forms.

Refactor Whups_Ticket::addAttribute() to not add attribute fields to the form,
but retrun attributes instead. Add attributes fields inside the form
constructors.

[cjh] Include attribute values in ticket emails, including "diffs" for changes
(Bug #1083).

[cjh] When replying to a restricted comment, default to the same restriction
(Request #4902).

Bump year, looks like a missed a few last time.

Rename $whups to $whups_driver

Combine the People tab with the Update tab.

due dates now have hours and minutes. This is a big commit just for that, but
I needed to add a custom renderer because we don't have a datetime field in Horde_Form proper, and it was either this or add the hours/minutes seperately as
another field.

[cjh] Show the requester in search results (rodion (at) nezna (dot) com,
Bug #2820).
[cjh] Show either the Comment or Update tabs depending on permissions,
but not both.
[cjh] Report the last-updated date for tickets (Bug #2396).
[cjh] Tickets now have an optional due date field.

the form name changed
Bug: #4100

Move the ticket editing form to lib/Forms (Ben Klang, Bug #4100), and rename it to EditTicketForm.

more reference cleanup - keep them for forms since  is an object, but remove where not needed elsewhere. some of these are php 4.4 fixes

Don't exclude unconfirmed states from ticket update.

Happy new year\!

Check for a result from getGroupMemberships() before calling
array_keys() on it.
Bug: #2818

Update and People tabs aren't ready for guest access.

[cjh] Add links to Update/Comment from individual transactions, which quote
that transaction's comment text (Bug #823).

[cjh] Add explicit permissions for assigning and updating tickets
(tmerritt@email.arizona.edu, Bug #1955).

convertCharset() is no longer necessary.

Show full group names.

Bug: 1818

Fix a bunch of places where we were either unnecessarily calling
isValid() in addition to validate(), or where we weren't checking
validate() at all.

remove @version

[cjh] Fix group-restricted comments (Bug #1225).

Convert charsets.
Bug: 1127
Submitted by: david (at) tmv (dot) gov (dot) tw

Happy New Year

On second thought, better not to pollute common-header.inc with the menu.

Use new <ul> menu. Consolidates things even a bit more.

Registry::getParam() -> Registry::get().

Everything *should* work now. Next step - replace/revamp ticket email
notifications.

Use $ticket->setDetails() to avoid a bunch of duplicated code.

I've now tested everything except Set Type and Set Queue, and it's
working. I'm sure someone will find a bug or two, of course.

More progress, cleanup, slimming, and updates. This is getting closer
to finished, but still isn't really tested. Need to get it into CVS so
I can hack at it on other machines, though.

Today's crop of Whups work.

fix paths and nextId() call.

Submitted by: Johan FISCHER <linux@fischaz.com>

Latest round of work on Whups. More things work, not everything.

More work on re-organizing Whups and moving towards the new whups_logs
format. This still isn't complete, but I'm trying to get myself to
finish it so I'm getting it to another machine.