Revisions for whups/search.php

Don't allow *only* a queue_id to signify an existing search since this
will be set if only a single queue exists in Whups (to avoid the select menu).
Use a flag to indicate we are returning to an existing search instead.

Tags: WHUPS_1_0

revert

Only attempt to validate the form if it was submitted. Avoids errors on
each date field about all date components not being selected.

Add date properties in an AND branch when saving as query.

Tags: WHUPS_1_0_RC2

Add date search criteria (Duck <duck@obala.net>, Request #7274).

Add button to save searches as queries (Request #5921).

Add missing argument.

Limit Robert's copyright to the years of his contributions. We should really find him.

Tags: WHUPS_1_0_RC1

Show public queries if not authenticated.

[cjh] Combine Type and Category selects in search form (php@ideacode.com,
Request #4928).

Greatly simplifies a few things, too.

@define -> define

Happy New Year

Fix searches from queue summary page

Refactor SavedQueries class out of template file and into Whups_View_SavedQueries

remove commented out code

Start moving older template code into a Whups_View_* structure

Fix searching all categories when no categories are selected.
Bug: 5929

Bump year, looks like a missed a few last time.

Rename $whups to $whups_driver

Always use $_SESSION['whups'] as the container for our session data.

remove deprecated saveSearch() call.

[cjh] Remove saved searches (Request #4897).

Move query data to a dedicated table, just use shares to manage query
permissions.

Happy New Year

Assign copyright to The Horde Project for those copyright holders that already agreed to it.

Change form methods to "get" to allow easier bookmarking of searches.

no searching by id in saved searches, and make saved search links work again

Add the search form to the lib/Forms collection; remove search by id since the upper-right-hand box provides that, and hide queue selection if there's only one queue.

- remove unnecessary singleton
- block ticket search results are now dynamically sortable
- remove some unused constants

Batch of Horde_Form::singleton() removals.

[cjh] "My Bugs" page is now a Horde_Block layout (Request #3202).

Happy new year\!

save summary criteria in search results qUrl and saved search url.
Bug: 2814

These uppercase variable names always annoyed me.

put search url into the session for guests, too.

[cjh] Add a link to return to the list of search results, along with the
previous/next links (Bug #1751).
[cjh] Fix the Quicksearch links.

Revert.

Add ability to search by ticket requester.

Bug: 1916

"after the patch to honor creator permissions, the ticket search page
no longer allows users to search queues they don't have PERMS_READ on.
They should be allowed to search for their tickets.  Attached is a
patch that fixes this."

Submitted by: tmerritt (at) email (dot) arizona (dot) edu

Fix a bunch of places where we were either unnecessarily calling
isValid() in addition to validate(), or where we weren't checking
validate() at all.

fix varname

[cjh] Queries are stored as Horde_Share objects with full permissions.
(Bug #1481).
[cjh] Delete queue permissions when deleting a queue (Bug #1462).

Fix some broken html

remove @version

Happy New Year

On second thought, better not to pollute common-header.inc with the menu.

Use new <ul> menu. Consolidates things even a bit more.

make saved searches work again.
Possibly not the cleanest way to do this, but it works.
Bug: 634

Registry::getParam() -> Registry::get().

Since it's currently not working anyway, I'm going to go ahead and
commit this removal of the clients code from Whups. This way we'll
have a clean slate going forward.

This variable isn't needed.

Ticket creation is now wrapped in lib/Ticket.php too. No ticket email
is sent inside the SQL driver anymore; all email notification will be
handled by Whups_Ticket::. At the moment, no email will be
sent. Adding emails back is the next step.

Search.php doesn't exist anymore.

More progress, cleanup, slimming, and updates. This is getting closer
to finished, but still isn't really tested. Need to get it into CVS so
I can hack at it on other machines, though.

[cjh] Add a 'summary' search option in the basic search form (Bug #269).

[cjh] Add previous/next navigation when there's a current list of search
results to navigate through.

Don't try to show saved queries and searches for guests.

We need to urldecode() $QUERY_STRING first.

We need a ? at the beginning of the url for removeParameter to work on it.

Add a list of a user's saved queries on the search and mybugs pages -
should include links to edit/delete them too, eventually; right now
it just runs them.

- don't need a whole new line for "Clear Saved Searches"
- make sure there's a little space between tables

No more HORDE_LIBS.

remove this (it's not used any more)

This *should* finish off the Module -> Queue conversion, including in
the SQL. Needs to be tested and ironed out before being ported to
dev.horde.org and marked done, though.

Use Queue instead of Module. Database fields have not been
touched. I've tested this, but it's also possible that some forms may
need to be tweaked to work, and that the UI may still say "module" in
some places.

* Use Variables::getDefaultVariables() instead of Horde_Form::getDefaultVars()
* Delete Horde_Form::getDefaultVars()
* Make sure that appropriate files require 'Horde/Variables.php'

* Delete Horde_Form_Vars::, use Variables:: instead.
* Delete Horde_Form_Renderer_rows::, was only used by Hermes and depends on
Horde_Form_Vars:: cruft.

more double ;

All footers look the same, so why not use only one.

These are by no means private constants. Remove the weird leading _
(it was my idea in the first place, for the record. Dunno why).

Happy new year everyone.

Centralise tests for the existence of a Whups client source.

Rework the Links driver to use categories instead of a custom sql table,
from Bo Daley <bo@tilda.com.au>

Big patch, some things may break/need to be tweaked. Here's Bo's description:

Attached is a first shot at reworking the Links API to use categories instead of
its own SQL driver. I haven't yet taken this as far as it can go, but already
it has resulted in a significant performance improvement for pages in my system
with large numbers of linked clients. (some of the pages that were previously
taking 20-30 seconds -- eg. the Whups search page -- are now down to about 5
seconds, which makes them a bit more usable).

Things that should be noted before this gets committed:

* I modified Turba so that the backend's read() function returns an array of
contact objects rather than just a single object (which speeds up handling of
large lists of objects). I don't know any ldap so this change will break the
ldap backend unless someone can make the same change to
turba/lib/Driver/ldap.php

* I've included a script (migrate_links.php) that creates links in the new
structure for people who were using clients in Whups. It doesn't update links
for other apps that might have been using Links but I can probably add that in
too if anyone needs it.

* reverse links don't seem to be working just yet. I'll get onto this soon.

more soon... hopefully i haven't missed anything else..(!!)

This patch silences a warning on the ticket search results page when
no clients were selected for searching.

Submitted by: Bo Daley <bo at tilda dot com dot au>

Use the new Util:: class.

Make sure clients functionality disables itself if the clients/ API
isn't there.

Submitted by: Bo Daley <bo@tilda.com.au>

Move more of whups to the updated client access through Turba.

Submitted by: Bo Daley <bo@tilda.com.au>

Allow searching tickets by client.

Submitted by: Bo Daley <bo@tilda.com.au>

Always show saved searches.

[cjh] Allow clearing of all or individual searches (Bo Daley
<bo@tilda.com.au>).

Implement searching based on ticket type.

Submitted by: Bo Daley <bo@tilda.com.au>

Another batch of menu.php -> ::menu() changes.

Fix license URL.

new horde_form syntax

Fix a formvars problem.

- Handle saved searches with categories specified correctly
- Some shorter menu items

Use $whups instead of $backend to avoid potential naming clashes
between apps (at least, make them much less likely).

use the new reset button code available in Horde_Form, these are the few places where it seems to make sense to include a reset button

Bump year.

Start converting some redirects to just require statements where we
can. This saves some loading of libraries and variable setup, and
saves an HTTP redirect as well.

Comments on this? I'm thinking of trying to do it in more places, to
streamline our app flow a bit.

- make some comment fields not required in Whups
- fix some problems in Hermes
- change how multienums are handled - don't need [] in the name anymore
  ([] now is ONLY used for the row renderer)
- add category to the whups search form.
- add the ability to assign tickets to someone on ticket creation.

Move the search result column definitions into a common function.

Fix searching when an id isn't specified.

Cosmetic patches from Brian Keifer <brian@valinor.net>.

- Token:: renamed to Horde_Token:: for consistency and future packaging
- Horde_Forms now use Horde_Token by default to prevent them from
  being reloaded.
- A bunch of Whups bugs fixed
- A few minor Horde_Form ones, too.

Don't save searches of guest users.

More flexible permissioning; distinguish between who can add to a
module and whoc an search it (_PERMS_READ vs. _PERMS_EDIT, which you
must have to add a new ticket).

Also, more permissions checks in various places, and better error
checking (permissions and otherwise) when viewing a ticket, so that
non-existant tickets or ones you shouldn't have permissions to view
are caught better.

[cjh] Search results can now specify the results title header.
[cjh] Reports currently lacks pretty graphs, but now shows more useful
      information - all assigned and requested tickets.
[cjh] Fix usage of Horde_Form_Vars:: class.

phase 2: complete the renaming of FormSprocket:: to Horde_Form:: and
GraphSprocket:: to Horde_Graph::

Better enforcement of permissions on modules, especially
during searches.

Prefs:: automatically saves dirty prefs at the end of a request.

- whups now has a standard horde menu
- add an Options screen
- fix a bunch of bugs
- convert to the Notification framework
- remove a bunch of unneeded code.