Revisions for whups/lib/base.php

Limit Robert's copyright to the years of his contributions. We should really find him.

Tags: WHUPS_1_0, WHUPS_1_0_RC2, WHUPS_1_0_RC1

Add @package tag.

@define -> define

Bump year, looks like a missed a few last time.

Rename $whups to $whups_driver

Move datetime form variable to Horde_Form.

due dates now have hours and minutes. This is a big commit just for that, but
I needed to add a custom renderer because we don't have a datetime field in Horde_Form proper, and it was either this or add the hours/minutes seperately as
another field.

more reference cleanup - keep them for forms since  is an object, but remove where not needed elsewhere. some of these are php 4.4 fixes

Happy new year\!

ws

Happy New Year

Registry::getParam() -> Registry::get().

Make sure that Whups does output compression, tweak comments.

No more HORDE_LIBS.

Remove includes of Browser.php that are no longer needed.

Config:: and Help:: moved to framework packages.

Browser:: is now a framework package.

[cjh] Various $no_auth and $self_contained_auth flags have been standardized
into an AUTH_HANDLER constant, which if defined signals the application
that it should not check permissions upon calling $registry->pushApp(),
as the calling script will handle that itself, or is a system-level cron
job/script/etc.
[cjh] Add an option to $registry->pushApp() to specify whether or not to check
application permissions.

[cjh] The 'allow_guests' setting, and $registry->allowGuests(), have been
removed in favor of Horde_Perms application permissions.

Instantiate a global  object in core.php.

Move Horde_Perms to framework.

Move Horde_Group to framework.

updated paths for Horde_Form

Registry::pushApp() permissions cleanup

* Don't use constant when raising permissions error from pushApp().
* Pass error from pushApp() to user.

If we get an error in pushApp(), check for the specific case that it is a
a permissions issue and redirect to login if so.

This is a hack to avoid a circular dependency: you need to authenticate to
push an app and you need to push an app to check whether to allow guests to
authenticate.  This is visible in apps which allow guests after the session
expires, for example.

Happy new year everyone.

Add the Horde_UI package, with the Horde_UI_Tabs class replacing the
Actions class in Whups, and now available to other Horde apps.

("Jason M. Felice" <jfelice@cronosys.com>)

We push the last_login time onto the $notification stack, so we need to set up notification before checking authentication (probably only an issue for transparent auth).

Use horde/lib/core.php in all applications. For now, I've commented
out the HORDE_LIBS-based includes in core.php and we're still using
the old HORDE_BASE . '/lib/' includes everywhere. But the HORDE_LIBS
constant is now available everywhere and core.php is included to
properly set up the base framework.

I also hit a bunch of other base.php things while I was at it:

- always check the results of $registry->pushApp() and display an
error if it fails.

- removed old cache_ssl code which is handled by
Browser::downloadHeaders() now.

- make sure all base.php files check authentication (you may need to
specify allow_guests = true on some applications that were open
beforehand).

- move the auth check up as soon as possible so as not to do
unnecessary work.

- remove libraries and code that aren't used.

- try and organize files consistently.

- probably a few other minor things.

Please test out everything as you can and report problems or syntax
errors; I'm sure I missed a thing or two.

Use the new Util:: class.

Simplify driver instantiation even more.

No hardcoded params anymore.

tweak the  element naming

[cjh] Allow clearing of all or individual searches (Bo Daley
<bo@tilda.com.au>).

Allow self contained authentication

Fix license URL.

[cjh] Add a new API call, Auth::isAuthenticated($realm = null), for
determining whether or not a user is logged in to the current
realm (by default null). Auth::getAuth() is still used to get
the current user, but now you don't need to know the auth realm
to get the current user - just to check authentication.

This commit replaces Auth::getAuth() with Auth::isAuthenticated()
where appropriate. Hopefully I didn't miss anywhere or cause any
problems; let me know if you find anything.

Use Browser::singleton().

Fix viral typo.

Use $whups instead of $backend to avoid potential naming clashes
between apps (at least, make them much less likely).

Revert the mess. I hope I got all files and correct rollback positions.

Jan, all this is what is necessary to get the summary screen and
registry calls working again after your changes - and this is only for
the apps currently on my summary; I'm missing a bunch. Are you SURE
standard.php is worth it?

Mike Cochrane: please revert the rest of your changes now. They were
not necessary, and they defeat the entire point of putting that code
in one place and only doing it once.

require_once => require on standard.php so registry calls work.

Condense some code from the applications' base.php files into standard.php.

Bump year.

Added Horde::authenticationFailureRedirect().

pass along parameters here.

More flexible permissioning; distinguish between who can add to a
module and whoc an search it (_PERMS_READ vs. _PERMS_EDIT, which you
must have to add a new ticket).

Also, more permissions checks in various places, and better error
checking (permissions and otherwise) when viewing a ticket, so that
non-existant tickets or ones you shouldn't have permissions to view
are caught better.

phase 2: complete the renaming of FormSprocket:: to Horde_Form:: and
GraphSprocket:: to Horde_Graph::

This should work; will do more extensive testing later.

Revert last commit. My PHP is broken.

Fix template path.

Might make SVG reports a bit more reliable.

Comments in the .dist file!

And, we now use a regular $params array, instead of a DSN.

fix a few style nits.

- whups now has a standard horde menu
- add an Options screen
- fix a bunch of bugs
- convert to the Notification framework
- remove a bunch of unneeded code.

Whups now uses the FormSprocket:: API for all form handling.

have to cache the SVG objects.

- Make sure to silence warnings in safe_mode
- Consolidate a whole bunch of code. Yay simplicity.

use $registry->getParam()
use WHUPS_TEMPLATES
let Types be either global or linked to a specific module.

rename Backend to Driver - I think all of the apps are consistent now.

Lots of work on WHUPS. Make assignment actually work
without whups-specific users, remove unused files, remove whups-specific
users, cleanup, etc.

Ok, this is a bit of a big commit, I'll be more incremental in future.

Changes to the look - it's a bit more horde like now.
Changes to the forms, as much html as possible has moved out of the forms
and into the renderer.  Forms also know how to execute themselves, which
is a better design.
Changes to the ui, especially the details page.  The four edit ticket forms
have moved to links at the bottom and the forms only appear when you
actually want to perform that action.

Biggest addition - the Advanced Query Builder.  This is more complex - I'll
describe it in a mail to the whups list in a bit.

assignment/user patches
Submitted by: Alex L.

a lot of references cleanup/optimization

remove the last session_start calls that shouldn't be there

Use HORDE_BASE where appropriate.

Chora -> Whups (woops)

This constant style is neater.

Cleanup: change all the $conf['paths'] variables to query this information
from the registry using the new API functions:

getTemplatePath(), getWebRoot(), getFileRoot(), getGraphicsPath()

Update your config files!

Revert the last registry change.  It would break things under certain
circumstances.

Pass the current application name to the Registry constructor instead of
explicitly calling $registry->pushApp().

use &Registry::singleton() to get the registry object.

- Fix errors caused by having error_reporting set to E_ALL.

- Fix license to be BSD, as intended/requested by original contributor

- Fix short tags (<?) - change to <?php

Code reorganization, to bring Whups more in line with the modern Horde
framework layout.  Please feel free to change the names of files in
lib/, where functions are defined, how they're grouped into files,
etc. as you see fit!

I did not alter any functionality at all with these changes... however,
one result is that error_reporting() is now at E_ALL, and this has
revealed a lot of issues that need to be dealt with (Undefined index
and property all over).  However, the code is functional as it was before.