Revisions for whups/lib/Whups.php

MFB: 1.185.2.1

Fix linking to queries if URL rewriting is turned off.

Add RSS feed for queries. We still need to link to them from somewhere.

Tags: FRAMEWORK_3, WHUPS_1_0, WHUPS_1_0_RC2

We might have a slug here as well

Reorganize query scripts to allow pretty urls.

Limit Robert's copyright to the years of his contributions. We should really find him.

Tags: WHUPS_1_0_RC1

Add form replies.

Reduce indention, don't wrap.

If we don't have update/assign/requester permissions and thus use the
PERMS_EDIT permission, then lock out guests.

Set type only with update permissions.

Allow to specify field types and parameters for attributes.

Add auto-completion to retrieve requesters from the address book.

Add per-queue permission to manually set the ticket requester.

Deal with queue vs. admin permissions more consistently.

Catch empty personal property.

Catch missing name parts.

Use MIME::parseAddressList(); return full name with user details for guest
users; accept a hash in formatUser() to avoid calling getUserAttributes()
twice; wrapping.

[cjh] Use pretty URLs if Horde is configured for them (Request #5922).

Fix PHP-side sorting of numeric columns

Re-run search when re-sorting so that ids in the session get re-sorted also
Bug: 2723

simpler way to reduce an array of booleans

Bump year, looks like a missed a few last time.

Rename $whups to $whups_driver

Use $GLOBALS instead of global.

The query page works fine now for guests.

- use H for history access key since it's available now
- null style

have to use a real permission, not 'update' or 'assign', here.

I think we need to fall back to main queue permissions if subpermissions don't exist.

This should fix hasPermission() for regular permissions...

hasPermission was being more permissive than permissionsFilter,
causing several inconsistencies and incorrectly showing the "Set
Queue" tab to guests.

Combine the People tab with the Update tab.

Use Horde_Array::array_merge_recursive_overwrite().

Vhost'ed mime driver configuration.

[cjh] Allow changing ticket queues as long as the user has DELETE permissions
on the current queue and EDIT permissions on the new queue
(tmerritt@email.arizona.edu, Request, #4268).

[cjh] Show the requester in search results (rodion (at) nezna (dot) com,
Bug #2820).
[cjh] Show either the Comment or Update tabs depending on permissions,
but not both.
[cjh] Report the last-updated date for tickets (Bug #2396).
[cjh] Tickets now have an optional due date field.

Move the admin forms to lib/Forms and the admin script to admin/; goal
is to break it into smaller scripts eventually.

more reference cleanup - keep them for forms since  is an object, but remove where not needed elsewhere. some of these are php 4.4 fixes

- remove unnecessary singleton
- block ticket search results are now dynamically sortable
- remove some unused constants

Add CAPTCHA support to the Add Comment and Create Ticket forms.

Add access keys to tabs

[cjh] Fix permissions checking for ticket comments when an admin user is the
one making the comment (Bug #2673).

Happy new year\!

Queues can only be set by admins atm.

Fix permission checks.
Bug: 2629, 2635

Show version in search results.

Wrapping

"@access public" is redundant.

Clean up class variable phpdoc.

phpdoc constant cleanup.

Update and People tabs aren't ready for guest access.

[cjh] Add explicit permissions for assigning and updating tickets
(tmerritt@email.arizona.edu, Bug #1955).

[cjh] Honor creator permissions on tickets (tmerritt@email.arizona.edu,
Bug #1945).

[cjh] Implement ticket watchers (tmerritt@email.arizona.edu, Bug #867).

[cjh] Enforce permissions on queues in reports, let guests see reports
if they have permissions (Bug #1812).

Make sure History tab is highlighted when it should be.

not entirely happy with this hackish optional parameter, but need to
treat reminders slightly differently to not use the always_copy
setting, and if there's no ticket_id, then don't say Tickets # in the
subject of generated mail.

[cjh] Allow administrators to delete attachments (Bug #1252).

Happy New Year

[cjh] Remove the Attachment tab, as it currently serves no purpose beyond
the Comment tab (Bug: #868).

phpdoc

current, not menuselected with the new menu.

Helps to add the file I put back. Also add a parameter to tell
Whups::getMenu() whether to return an object or a string.

Use new <ul> menu. Consolidates things even a bit more.

Apps using Horde_UI_Tabs should call Horde::applicationUrl() on their own. Makes javascript: urls much simpler to handle, etc.

Change all references to *.gif images to the new *.png.

change getParam('graphics') to getImageDir()

Since it's currently not working anyway, I'm going to go ahead and
commit this removal of the clients code from Whups. This way we'll
have a clean slate going forward.

Fix undefined key for empty client lists.

avoid starting property names/sql aliases with '_' characters.

Bug: 595

- rename to Relationship_Manager.php, going into
Horde/Relationship/Manager.php (better PEAR semantics).

- Remove last UI bits from Links. Will be completely re-done
somehow. Can use poor man's visualization for now. :)

Some of the Links removal. Lots of stuff to sort out here.

Make sure what we're sorting by is defined.

Need to instantiate Mail_RFC822 to avoid static method fatal errors with PHP5.

Apps no longer need to call Help::javascript() - and indeed they shouldn't,
since it no longer exists.

Take a shot at showing ticket owner changes too.

Basic shot at consistent ticket email. Will undoubtedly need to be
tweaked, but it's a start. Should send email on all new tickets and
updates.

Bug: 46

Fix sending of reminders.

Set comment_text when relevant. (Mike Bydalek <mbydalek@mobilemini.com>)

I've now tested everything except Set Type and Set Queue, and it's
working. I'm sure someone will find a bug or two, of course.

More progress, cleanup, slimming, and updates. This is getting closer
to finished, but still isn't really tested. Need to get it into CVS so
I can hack at it on other machines, though.

Fix viral typo.

Today's crop of Whups work.

Latest round of work on Whups. More things work, not everything.

More work on re-organizing Whups and moving towards the new whups_logs
format. This still isn't complete, but I'm trying to get myself to
finish it so I'm getting it to another machine.

Consistency in method organization and naming (clients/searchClients, etc.)

Fix parse error.

- Don't need clientsConfigured, just check if getClientSource() is non-empty
- More condensation/cleanup/renaming.

- Group ticket histories by transaction, not by individual change.
- Try a (hopefully) slicker look for the ticket histories in the ticket display.

Empty comment ids get passed through here.

No more HORDE_LIBS.

This *should* finish off the Module -> Queue conversion, including in
the SQL. Needs to be tested and ironed out before being ported to
dev.horde.org and marked done, though.

Use freshmeat style to obscure email addresses.

Allow passing a userid to Whups::permissionsFilter()

Don't throw errors if 'name' isn't set.

Hide most of the useful bit of email addresses in display situations.

Bug: 19

queues, not modules

Use Queue instead of Module. Database fields have not been
touched. I've tested this, but it's also possible that some forms may
need to be tweaked to work, and that the UI may still say "module" in
some places.

* Delete Horde_Form_Vars::, use Variables:: instead.
* Delete Horde_Form_Renderer_rows::, was only used by Hermes and depends on
Horde_Form_Vars:: cruft.

Move Browser::downloadUrl() to Horde::downloadUrl() because of
reliance on framework components (/download/ directories, etc.). This
was the only part of Browser:: that wasn't independant of other parts
of Horde.

move Menu.php to a framework package.

Use Identity::singleton().

* Remove Whups_Driver::getClients() and move back into Whups::.  This is not
driver-specific.