Revisions for whups/lib/Query.php

MFB: 1.73.2.1

Fix ticking attribute checkboxes when editing attribute queries.

Correctly implement editing of date criteria.
Bug: 7274

Tags: FRAMEWORK_3, WHUPS_1_0, WHUPS_1_0_RC2

Add date search criteria (Duck <duck@obala.net>, Request #7274).

Add RSS feed for queries. We still need to link to them from somewhere.

Reorganize query scripts to allow pretty urls.

Add query slugs. Reordering scripts for rewrite support in a minute.

Start implementing editing of query elements.
Setting the forms works already, but is not enabled yet, because saving is
still missing.

Nuke global variable.

Limit Robert's copyright to the years of his contributions. We should really find him.

Tags: WHUPS_1_0_RC1

Last two $conf['shares'] typos.

Split out query forms.

[cjh] Allow turning off a user's ability to edit share permissions (Request #4054).

Bump year, looks like a missed a few last time.

Rename $GLOBALS['whups'] references to $GLOBALS['whups_driver']

Rename $whups to $whups_driver

Remove unused property.

Move query data to a dedicated table, just use shares to manage query
permissions.

remove unneeded refs

Temporary fix for queries, from Duck.

Fixes for attribute queries.

- remove unnecessary singleton
- block ticket search results are now dynamically sortable
- remove some unused constants

More access keys in tabs.

Happy new year\!

I guess everyone was kidding when they said you should use curly
braces for string offsets. This is, if anything, relevant to PHP6 (and
E_STRICT warnings under 5.1), but may as well just get rid of it.

ws

Simpler test for non-empty arrays

Allow to search for versions.

Simplify query editor by not requiring to select a ticket type first. Instead
we provide all states, priorities, and attributes for all types at once now.

Another reference

Reference.

Reference.

Only included attributes into query that are ticked.

"@access public" is redundant.

Clean up class variable phpdoc.

Calling reset leads to an internally inconsistent query object. Use New Query instead.
Bug: 2094

Don't use array_push() if we don't need to.

open the perms editor in a new window if the onclick javascript isn't
run. should work for both js (nicer) and non-js now.

[cjh] Queries are stored as Horde_Share objects with full permissions.
(Bug #1481).
[cjh] Delete queue permissions when deleting a queue (Bug #1462).

[cjh] Queries can now be deleted (Bug #1193).

Sanity check loaded queries.

Happy New Year

[cjh] Allow inserting explicit Type filters into Query Builder queries
(Bug: #434).

- also note some brokenness with some of the text operators, fix
another for pgsql, disable one that doesn't seem to useful (case
sensitive text matching?), and reorganize the query display pages a
bunch.

few more @package tags

lots of phpdoc still needed, but at least mush comments into the right
format.

Fix some things that don't need to be references.

Add Queue to the possible query builder criteria.

Fix honoring of checkboxes for whether to search summary, comments,
or both.

Add ability to search for tickets by what group owns them.

Add a list of a user's saved queries on the search and mybugs pages -
should include links to edit/delete them too, eventually; right now
it just runs them.

Use Queue instead of Module. Database fields have not been
touched. I've tested this, but it's also possible that some forms may
need to be tweaked to work, and that the UI may still say "module" in
some places.

* Delete Horde_Form_Vars::, use Variables:: instead.
* Delete Horde_Form_Renderer_rows::, was only used by Hermes and depends on
Horde_Form_Vars:: cruft.

Happy new year everyone.

Re-work how we handle custom form renderers, and hopefully make them a bit
easier to use/more useful.

Horde_Form_Renderer::_renderForm() no longer bails out with a custom renderer
and calls a render() method, which doesn't actually exist in the base class.
Instead, there is a Horde_Form::getRenderer() method (which replaces
Horde_Form::getCustomRenderer()) that simply returns the correct renderer
for the form. You then just use that instead of $renderer = &new Horde_Form_Renderer()
- the base class will return a basic Horde_Form_Renderer for you.

In the custom form renderer class itself, you just extend the Horde_Form_Renderer
class and override any methods that you want to alter, instead of necessarily
having to re-write the whole render() loop.

I've updated every occurrance of any of this code that I can find to take
advantage of this new architecture, and made a few minor tweaks while I
was at it. Also, some phpdoc comments for the custom renderer stuff.

PHP 5 fixes.

Fix a bunch of query builder stuff; you can search by owners again now.

fix some terminology

Fix license URL.

use the new Form.php syntax for setting up variables

Use $whups instead of $backend to avoid potential naming clashes
between apps (at least, make them much less likely).

Bump year.

Added an api method to execute a batch of queries, returning the results
either as just the ticket ids, or as the full details.

Fixed the getTicketsByProperties method when $munge is false

Added parameterised queries
Split the execute query function into it's own page (runquery.php) - this
can take a query= getvar naming a query to load and execute
Fix the sql query driver to allow searches on more than one attribute or
comment by joining into the other tables more than once

Added searching attributes to the Query Builder.
Implemented the rest of the text search types for executing queries.
Slight changes to the results page when executing queries.

Fix a bunch of query builder stuff, including being able to change the
ticket type.

- Token:: renamed to Horde_Token:: for consistency and future packaging
- Horde_Forms now use Horde_Token by default to prevent them from
  being reloaded.
- A bunch of Whups bugs fixed
- A few minor Horde_Form ones, too.

More flexible permissioning; distinguish between who can add to a
module and whoc an search it (_PERMS_READ vs. _PERMS_EDIT, which you
must have to add a new ticket).

Also, more permissions checks in various places, and better error
checking (permissions and otherwise) when viewing a ticket, so that
non-existant tickets or ones you shouldn't have permissions to view
are caught better.

phase 2: complete the renaming of FormSprocket:: to Horde_Form:: and
GraphSprocket:: to Horde_Graph::

Fix the Query Builder. Not everything, but probably everything that _used_ to
work, and a bunch - like actually executing the query and getting tickets back -
that didn't, all work now.

Whups now uses the FormSprocket:: API for all form handling.

update Form constructors

more work on types/modules linkage, fix query builder to some extent
(REC, you probably need to look at this), style, etc.

oodles of style

Add basic gettext framework. Far from complete as is Whups.

Ok, this is a bit of a big commit, I'll be more incremental in future.

Changes to the look - it's a bit more horde like now.
Changes to the forms, as much html as possible has moved out of the forms
and into the renderer.  Forms also know how to execute themselves, which
is a better design.
Changes to the ui, especially the details page.  The four edit ticket forms
have moved to links at the bottom and the forms only appear when you
actually want to perform that action.

Biggest addition - the Advanced Query Builder.  This is more complex - I'll
describe it in a mail to the whups list in a bit.