Revisions for turba/browse.php

MFH: SECURITY: Fix unchecked access to contacts in the same SQL table (Bug #6208).

Tags: TURBA_2_1_7

MFH:
1.126     +2 -3      turba/browse.php
1.131     +2 -3      turba/search.php
1.42      +2 -2      turba/index.php

Tags: TURBA_2_3, TURBA_2_3_RC1, TURBA_2_2_1, TURBA_2_2, TURBA_2_2_RC4, TURBA_2_2_RC3, TURBA_2_2_RC2

Don't re-define TURBA_BASE when we include it from index.php.

Happy New Year

Happy New Year

Merge from HEAD.

Not sure if there will be a 2.1.5 release or not, but I needed to fix this to properly test the 2.2 upgrade scripts, so I might as well commit it.

Tags: FRAMEWORK_3_1, TURBA_2_1_6, TURBA_2_1_5

Missed a few copyrights from Chuck.

Tags: BEFORE_MERGE_3_2, TURBA_2_2_RC1, TURBA_2_2_ALPHA

Bump year, looks like a missed a few last time.

MFH: 1.122

Tags: TURBA_2_1_4

Rename $source to $default_source. Too many conflicts with that name in lib/api.php.

Standardize copyright wrapping and spacing.

Move BrowsePage to Turba_View_Browse with the other views. Needs to be
refactored more, but this moves in the direction of having things in
the same place.

We need base.php to set up things like include_path.

* Neatly decouple browse page processing from environment

* Move page handling code from browse.php -> lib/BrowsePage.php
* Use Variables:: instead of Util::getFormData()

Coding Standards: fixed "if(" and function definitions with opening brace
on same line.

MFH: 1.115

Tags: TURBA_2_1_3, TURBA_2_1_2, TURBA_2_1_1

grammar

MFH: 1.114

Redirect to default view if doing some actions here without being allowed to
browse the current address book.

Bug: 3587

Fix what looks like a mixed-up merge.
Bug: 3553

Tags: TURBA_2_1

Move this line to where it belongs...

Bug: 3385

Tags: TURBA_2_1_RC2

Merge XSS fixes to FRAMEWORK_3_0 branch.

Tags: TURBA_2_0_5

MFH 1.112 1.10

Tags: TURBA_2_1_RC1

MFH 1.113

MFH: 1.113

When moving or copying contacts, use getValue() for each target driver
attribute instead of a single getAttributes() for the source object. This
takes composite fields into account etc.

Fixes for adding/deleting/displaying lists when a Turba share is involved.

MFH: 1.111

Bad choice of variable name.  This one is defined in $GLOBALS already.

MFH 1.110

Turba_Driver::delete returns PEAR_Error on failure, not boolean.

MFH: Bug #2764

Use summary notifications for contact changes, instead of one notice
for each change.

Bug: 2764

Merged from HEAD.

ws

Tags: BEFORE_MERGE_3_1

quoting

address book

Fix broken browse actions for shared addressbooks.
Bug:2613
Submitted by:tevans (at) tachometry (dot) com

MFH: Use double-quotes.

Tags: FRAMEWORK_3_0, TURBA_2_0_4

Use double-quotes.

More complete error checking.

make sure classes are included where they're needed.

[cjh] Get rid of cached search results entirely, and move more display
code into Turba_ListView, simplifying a number of different
codepaths and avoiding servercide when using Advanced Search.

MFH:
[jan] Don't show "Add" icon if no writeable address books exist.
[jan] Don't show "Browse" icon and list if no browseable address books exist.

Tags: TURBA_2_0_3, TURBA_2_0_3_RC1

Don't show "Browse" icon and list if no browseable address books exist.

MFH 1.98 1.99

Don't $notification->push() more than necessary.

Check if the source is browseable before we perform the search.

Bug:2269

Add space.

Use the first addressbook in the user-chosen order for searching
defaults (matches the dropdown), but use default_dir for write
operations.
Bug: 1650

space

Let Turba_Driver::singleton() worry about loading the source config,
so we can avoid passing it in everywhere.

[cjh] Users can select which address books they wish to use, and in
which order they will be displayed (Bug #1650).

six of one, half a dozen ... use the same style comments throughout the file.

Remove Turba_AbstractObject, just use Turba_Object and
Turba_Object_Group. Also make sure that code supports future other
subclasses in lib/Object/*.php.

Try to allow creating new lists in any source that supports them (that
you have write access to). Doesn't target the right source yet.

better user notification

[cjh] Contacts can now be added to lists stored in any address book
(Bug #1561).

- also, lots of ui and code cleanup while I was there.

[cjh] Introduce a 'browse' setting on sources, seperate from the 'export'
setting, to allow differentiation of browseable and exportable
sources.

MFH 1.87 - Don't show addressbook selection menu when no browseable addressbooks.

Don't show the addressbook selection menu when there are no browseable addressbooks.

MFH 1.86

Fixes bug where if no browseable addressbook exists, search results would not display properly.
Also fixes bug where the browse attribute is ignored for a source is set as the default in turba prefs, thus allowing a non-browseable addressbook to be browsed if it was set as default.

Add permissions to restrict number of contacts per address book.

MFH 1.84

cleanup

MFH: we consistently put this kind of license into LICENSE, not COPYING.

This style of license lives in LICENSE, not COPYING.

MFH: Show actions and browse letters at the top and bottom of contact listings.
(Bug #1312, Bug #1458).

[cjh] Show actions and browse letters at the top and bottom of contact listings.
(Bug #1312, Bug #1458).

Fix statement order.

Bug: 1363

Tags: TURBA_2_0_2

MFH 1.81

Tags: TURBA_2_0_1, TURBA_2_0_1_RC1

More error checking.

Pass errors.

Pass errors.

[jan] Show list of edited contacts below edit form when editing several
contacts at once.

Retrieve only required fields from backend.

Happy New Year

Happy New Year

Happy New Year! :-)

Tags: TURBA_1_2_5, TURBA_1_2_4, TURBA_1_2_3

Use 'List' instead of 'Group' like everywhere else.

Tags: FRAMEWORK_3, TURBA_2_0

fix method name

Tags: TURBA_2_0_RC3

prevent copying/moving of groups

Bug: 935

Change to Turba::getMenu(), fixes the menu on the Options screen.

Bug: 898

space

Tags: TURBA_2_0_RC2, TURBA_2_0_RC1

Registry::getParam() -> Registry::get().

Tags: TURBA_2_0_BETA

Error checking/simplification in addMember/removeMember.

Merge Source.php into Driver.php and just use the Turba_Driver class
to handle everything.

- Turba simply needs a mapping to properly handle UIDs. Throw errors
(until we have it) where it matters.

- delete() instead of removeObject()

- Expect a 'uid' attribute. Need to add this to the default schemas
and such.

Don't show source selection dropdowns in cases where there would only
be one choice.

Submitted by: Francois Marier <francois@nit.ca>

Fix HTML nesting.
Bug: 252

Tags: TURBA_1_2_3_RC1

MFH: Update the license bits that have been out of date for years -
point to the Horde ASL-style license as defined in COPYING.

Update the license bits that have been out of date for years - point
to the Horde ASL-style license as defined in COPYING.

Just include attributes.php in base.php instead of multiple places.

No more HORDE_LIBS.

style

[cjh] The alphabetic pager now has an "All" option.

Lots and lots of copyright and license updates and fixes. Someone will have to that for the HEAD branches too.

From: Michael Rubinsky <mike@theupstairsroom.com>

The following patches turba to gracefully deal with login failures.  This was
specifically done because when a login or connection failure would occur with a IMSP
server (or any other backend for that matter) the browse display would display an error
about $pager and $numDisplayed not being defined or objects etc...  Also, in browse.php,
if the $driver is not set (which would happen during a login/connection failure) then the
header.inc and select.inc files would not be included.  This patch fixes these issues.

Tags: TURBA_2_0_ALPHA

This patch fixes a problem when using the alphabetic pager in Turba.  When the
addressbook is displayed by pressing the "Browse" menu icon, the source attribute was not
properly set, causing the pager to try to use the top most source in the directory list...

Submitted By: Michael Rubinsky <mike@theupstairsroom.com>