Revisions for trean/lib/Trean.php

Happy New Year

First round of copyright assignments.

Checking a boolean expression for ? true : false is always redundant.

Default to the user's own main bookmarks
Submitted by: duck@obala.net

Remove create_function usage, which in these cases was equivalent to max($allowed).

Bump year, looks like a missed a few last time.

Pretty big UI reorg. Reintroduce the folder tree, make most bookmark
actions work without javascript, introduce an actions panel, etc.

revert.

Call by reference

Clarify variable names a bit.

Consolidate code and remove unused code, more fixes, and remove some TODOs.

- remove as much usage of DATATREE_ROOT as possible.
- move much of the styling of the bookmarks list to CSS
- consolidate browse templates

- remove click and rating reports since we can sort by them now
- fix http status overview report
- consolidate search templates

[cjh] Add a preference for how to sort bookmarks (Request #2510).

remove unused function

[cjh] Move bookmarks from DataTree storage to a SQL table.

Probably still a few kinks to work out, but it works.

Standardize copyright wrapping and spacing.

http-Content-Type is a nice idea, but trim it in the interest of
reducing the number of fields bookmarks use.

Don't raise notifications inside classes.

Rename "categories" to "folders" to avoid confusion with Horde Categories.

Add a selection box to jump to a category (simular to IMP's
folder selection).

Happy new year\!

consolidate, strip spaces

default to http favicon. (#2497)

use "New Bookmark" in the menu for consistency.

"@access public" is redundant.
Specify "@access private" correctly in phpdoc.

Allow creating a new category when adding/editing a bookmark.

Add permissions to restrict number of categories and bookmarks.

phpdoc, wrapping, cleanup.

lots of html tweaks and cleanup, use the table striper a bit, and add some access keys.

be a bit more graceful if there's no vfs config.

* Try to get favicon.ico if a favicon could not be parsed
* Store Content-Type header and try to fall back on a mime icon

Report framework + first crude report

Allow user to take action on broken/redirected links

grammar

Add basic sharing functionality to the UI.

Add backend support for Horde_Share, though the UI doesn't reflect this yet.
Unfortunately, this breaks compatibility with Horde 3.0.x, but we're
shooting for a release with Horde 3.1.

be sure to run scripts/upgrades/2005-03-15_move_to_horde_share.php

Fix subcategories in select boxes

Bug: #1310

Use Horde_Tree to render <option> tags, resulting in a nicely sorted tree.

Ticket #1177

Bug 1176

Remove debugging statement

Error checking, -@version, fix portal block.

Performance improvements

Happy New Year

Trean::listAllBookmarks now works properly, and so does the
bookmarks/list API method. It also now returns a hash instead of
objects for better interop/less data being passed around through the
API. And, adjustments to Rakim to match these changes.

I think this fixes the bookmarks API. Ben? Btw, you should really grep
for methods to make sure they're used before deleting them...

fix portal block

error checking, cs

CODING_STANDARDS

call-by-reference vs. call-by-value

fix Trean::listCategories()

Restructured the bookmark storage to take better advantage of the natural
parent/child relationships that the datatree structure provides.

The most notable advantage of this is the ability to have bookmarks in
the root category (No more "You must have at least one category..."
messages).

Minor UI updates, more to come.

Instead of hardcoding '-1' in tons of places, use a new constant: DATATREE_ROOT. Much more readable, etc. At the same time, make this an int (-1) instead of the string value ('-1') which was inconsistent with all other datatree ids, buggy, etc.

current, not menuselected with the new menu.

- new bookmark and add graphics
- remove unused graphics
- use new <ul> menu

Apps no longer need to call Help::javascript() - and indeed they shouldn't,
since it no longer exists.

- strings instead of constants
- make sure all files have a header
- fix license references to all point to the actual LICENSE file.
- cleanups

package name

No more HORDE_LIBS.

move Menu.php to a framework package.

Show notifications only from the requested message stack.

- Move Category into the framework.
- At the same time, rename the API to DataTree.
- shorten some method names while we're at it.

Move Horde_Template to framework

Fix paths to Text.php.

Only show 1 level of categories in the main panel.

- add the ability to rename categories (Robert Ribnitz <ribnitz@linuxbourg.ch>)
- use more verbose constant names (no DEL or REN)

unless anyone has any objections...
- shift code out of templates and into the actual script files
- start migrating the templates to horde_template
- use a dynamic collapsable tree for the categories tree

Sort out a few more error checking cases in the category code.
Maintain the special -1 -> -1 mapping of the "root" category.

a few more error checking tweaks.

fix category usage

Another batch of menu.php -> ::menu() changes.

ZE2 fixes.

Previous attempt to add a getNumberOfChildren method failed; for now, just
pull the list and count them (which is tested and works).

Ensure that errors are displayed when adding a bookmark or category fails
(don't skip off to browse.php and thus lose the pushed notification).
Insist on at least one category before adding a bookmark (don't present
empty drop-down category list).  Fix typos.

Nuke a lot of constants.php files.

Specific Reason: constants should be defined in the application's base
class file UNLESS constants are needed in one of the configuration
files (the case for all those remaining). Only then should you break
things out to a seperate file (and even then, we may want to just
include the app's library file).

General Reason: Including files is *very* expensive. Short files are
pointless if we can avoid them; it's much cheaper to have slightly
longer files than multiple short ones (especially when we're going to
include all the short files anyways).

- More cleanup
- Cache $trean->getCategory() calls.
- *vastly* reduce number of SQL queries Trean generates.

correct names in add list.

Clean up a bunch of Trean, including adding sub-categories. A bunch of
this is still a mess.

Don't show Add Bookmark links when there are no categories to add to.

Submitted by: Michal <michal@michal.no-ip.com>

[mac] Don't show My Bookmark category on the add screen (Chris Albertson
      <alb@chrisalbertson.com>).
[mac] Cleanup the note at the bottom of the add screen (Chris Albertson
      <alb@chrisalbertson.com>).
[mac] Don't show the New Bookmark link for the root category (Chris Albertson
      <alb@chrisalbertson.com>).

Some fixes so Trean works with the new categories system.

- Chris Albertson <alb@chrisalbertson.com>

Fix call-time-pass-by-reference and some style stuff (Mike, read
CODING_STANDARDS! <g>).

Add Edit and Delete options and some XHTML fixes.

Add some 'it works fine for me' Bookmark Import code.

Tested with a mozilla and an IE bookmarks export and works fine. Imports into a 'Imported Bookmarks' category.

Initial Commit of Trean.