Revisions for trean/lib/Bookmarks.php

Use Horde_Permission

don't double-contruct Trean_Bookmark objects

Add missing String::convertCharset() calls
Bug: 6142

Happy New Year

If we're going to cast integer fields, cast all of them.

Make sure to log errors from sql statements.

add AS so that count parameter comes back correctly
Bug: 5062
Submitted by: x3n (at) molinier (dot) eu

Remove datatree references from class docs where sensible.

[cjh] Bookmark ratings can now be changed via a dynamic, CSS-based
star rater that saves new ratings but degrades to a real link
without JavaScript.

Will look better after some more work on the browse interface. Edit
screen needs to be fixed for setting the rating, also.

Specify types in MDB2 prepared statements.
Bug: 4849

Wrap SQL statements at a more readable length.

Fix method name.

fix variable name

Consolidate code and remove unused code, more fixes, and remove some TODOs.

Searching and status reports work again now.

- remove as much usage of DATATREE_ROOT as possible.
- move much of the styling of the bookmarks list to CSS
- consolidate browse templates

- remove click and rating reports since we can sort by them now
- fix http status overview report
- consolidate search templates

Happy New Year

Assign copyright to The Horde Project for those copyright holders that already agreed to it.

Validate $sortby

remove unnecessary references and unused function.

remove stray argument

[cjh] Move bookmarks from DataTree storage to a SQL table.

Probably still a few kinks to work out, but it works.

Standardize copyright wrapping and spacing.

the type attribute isn't actually used for folders even now.

remove unused function

[cjh] Give Trean its own Share implementation for now as hierarchical
shares are being removed from the main Horde_Share class.

Take advantage of share caching in Trean.
Maybe we want a separate configuration setting to turn this off or on in
Trean, in that case we need to check inside Trean_Bookmarks::singleton() if we
have a sufficiently new Horde_Share version.

Don't use datatree sorting for 'clicks', because it doesn't do integer
sorting properly.
Bug: 3842, 3843

Rename "categories" to "folders" to avoid confusion with Horde Categories.

Happy new year\!

fix variable reference warnings

whitespace <martin (at) mein-horde (dot) de>

delete favicon when deleting bookmark. (#3051)
martin (at) mein-horde (dot) de

fix reference warning

Fixes for reference warnings with PHP 5.1. If someone could merge
these it'd be appreciated, I'm not up to it right now and will be
swamped come morning.

Reference fixes.

Add permissions to restrict number of categories and bookmarks.

phpdoc

Add bookmark ranking.  The rankings report might not function right unless
you run the add_default_ranking upgrade script.

Show bookmark's parent category in the search results screen

[cjh] Fix bookmark export (Bug #1672).

Only use one datatree call to list bookmarks

More files I forgot to commit for the report cleanup. I must have really
been out of it last night

Allow tracking link clicks

Add basic sharing functionality to the UI.

Add backend support for Horde_Share, though the UI doesn't reflect this yet.
Unfortunately, this breaks compatibility with Horde 3.0.x, but we're
shooting for a release with Horde 3.1.

be sure to run scripts/upgrades/2005-03-15_move_to_horde_share.php

use sortByAttributes.

Note: This breaks compatibility with Horde 3.0.4-RC1

delete/move/copy multiple bookmarks at once

Sort category tree.  Still need to figure out how to sort the category
select box.

Sort bookmarks

Fix import/export...I think I actually got it this time

Error checking, -@version, fix portal block.

Error catching.

Performance improvements

Happy New Year

Add & use $bookmark->getParent() instead of using $category_id in the
bookmark view templates for general cleanup and also to avoid warnings
on the search results page.

Also general HTML cleanup while I was there.

Fix method name.

These neither.

This error message shouldn't be localized.

Cleanup and fix the bookmarks Horde_Block.

CODING_STANDARDS

Restructured the bookmark storage to take better advantage of the natural
parent/child relationships that the datatree structure provides.

The most notable advantage of this is the ability to have bookmarks in
the root category (No more "You must have at least one category..."
messages).

Minor UI updates, more to come.

fix function name

make sure bookmark names don't collide (Ben Chavet <ben@chavet.net>).

Instead of hardcoding '-1' in tons of places, use a new constant: DATATREE_ROOT. Much more readable, etc. At the same time, make this an int (-1) instead of the string value ('-1') which was inconsistent with all other datatree ids, buggy, etc.

Use DataTree attributes for bookmarks. Includes a conversion script that will make your bookmarks re-appear. :)

Submitted By: Ben Chavet <ben@chavet.net>

!isset() -> empty()

Make sure that importing of subfolders works.

error checking, and proper "All" value.

Pass errors from updateCategory() through.

- strings instead of constants
- make sure all files have a header
- fix license references to all point to the actual LICENSE file.
- cleanups

minor cleanup/phpdoc

No more HORDE_LIBS.

fix class names, use is_a()

Fix a few method names ("Jos W. van der Woude" <jos@veerkade.com>).

- Move Category into the framework.
- At the same time, rename the API to DataTree.
- shorten some method names while we're at it.

Happy new year everyone.

- add the ability to rename categories (Robert Ribnitz <ribnitz@linuxbourg.ch>)
- use more verbose constant names (no DEL or REN)

wordwrap

Sort out a few more error checking cases in the category code.
Maintain the special -1 -> -1 mapping of the "root" category.

ZE2 fixes.

Ensure that errors are displayed when adding a bookmark or category fails
(don't skip off to browse.php and thus lose the pushed notification).
Insist on at least one category before adding a bookmark (don't present
empty drop-down category list).  Fix typos.

Recusivly delete the sub categories when deleteing a category.

- More cleanup
- Cache $trean->getCategory() calls.
- *vastly* reduce number of SQL queries Trean generates.

Bump year.

- Fix searching
- Bookmarks in search results can now be edited or deleted
- Style cleanups

This might fix import again - someone want to give it a shot?

[cjh] Add deletion of bookmark categories
      (Arne Gellhaus <arne@gellhaus.de>).

Clean up a bunch of Trean, including adding sub-categories. A bunch of
this is still a mess.

More fixes, fixed searching, and started working on getting the
folders tree to just be displayed by our CategoryTree
library. Commented out for now, though.

foreach( -> foreach (

Quick hack to get trean kinda working again.

Add export option so you can now export your code in preparation for a re-write in a then next week...

Fix call-time-pass-by-reference and some style stuff (Mike, read
CODING_STANDARDS! <g>).

Add Edit and Delete options and some XHTML fixes.

Initial Commit of Trean.