Revisions for scry/vote.php

- Use .html.php for view templates (or whatever format is appropriate, like .xml.php)
- simplify templates directory depth

Happy New Year

Include files missed by autoloader.

Show permission check is done in getPoll() already. Redirect to view results/comments page after voting.

- check if poll is existing directly in getPoll()
- use count() for hasVoted inseted selecting data
- avoid some warnings

First optimization step reducing the number of queries and simplify query types:
- use just one simple query in getPolls() as retrieving polls ID separated is not needed and choices are retrieved by getVotes()
- track choice count on vote instead of having a join query to get the choices count
- cannot find any usage of poll_results_to so remove it
- use div and CSS insted of requesting the server for the pixel.php colored image
- add a dedicated and cached get poll function (getPoll still is called when lisitng polls several times for every poll)
- make getVotes() statis as we get them in the poll list then again later when chekig individual poll actions in isEditabe()
- remove settings the group permission. poll_group was droped last year so the cast to set the group permission never occurs
- use scry_voted cookie even to reduce DB access in hasVoted()

Permissions
- Avoid permission check overhead for common poll show/read task by do not set the permission of every poll as default permission on poll creation time. Create the default permission only when you actually pass to the permission editing form. Check the default permissions in the Scry::hasPermission function for non existing permissions.

Demographics
- Added demographics.php config file to define demographics groups
- Added hook to detect user demographics group belonging
- Add a drop down to which display between demographics groups in poll view

Others changes:
- spited read support in sql driver
- template -> view
- php5 constants and function definitions
- replace deprecated is_a with interface of
- autoload

Happy New Year

Assign copyright to The Horde Project for those copyright holders that already agreed to it.

Move forms to lib/Forms.

include missing class.

* Standardized poll management links
* Changed $scry->isVotable() to accept a poll_id for API consistency
* Remove need to pass $votes to $scry->isEditable()
* Only allow group to be set on poll creation.  Further permissions editing will be done with a new UI

* Implement per-poll permissions
* Scry::isEditable() no longer returns true if the poll is closed
* Drop storage of the poll group in the SQL driver

ToDo: Allow existing polls' permissions to be edited by users with PERMS_EDIT.  Probably will reuse Perms_UI if possible.

Remove unnecessary references and Horde_Form::singleton calls.

Happy new year\!

Fix viral method name typo.

Happy New Year

Use new menus.

Registry::getParam() -> Registry::get().

- separate out the inline block viewing from the regular vote script
- apply patch from Roel Gloudemans <roel@gloudemans.info>:
"Scry wasn't working from a giapeto block. The problem was that the page_id
parameter was missing from the url."

Fix form behavior when the form isn't valid.

No more HORDE_LIBS.

* Use Variables::getDefaultVariables() instead of Horde_Form::getDefaultVars()
* Delete Horde_Form::getDefaultVars()
* Make sure that appropriate files require 'Horde/Variables.php'

* Delete Horde_Form_Vars::, use Variables:: instead.
* Delete Horde_Form_Renderer_rows::, was only used by Hermes and depends on
Horde_Form_Vars:: cruft.

All footers look the same, so why not use only one.

Happy new year everyone.

Re-work how we handle custom form renderers, and hopefully make them a bit
easier to use/more useful.

Horde_Form_Renderer::_renderForm() no longer bails out with a custom renderer
and calls a render() method, which doesn't actually exist in the base class.
Instead, there is a Horde_Form::getRenderer() method (which replaces
Horde_Form::getCustomRenderer()) that simply returns the correct renderer
for the form. You then just use that instead of $renderer = &new Horde_Form_Renderer()
- the base class will return a basic Horde_Form_Renderer for you.

In the custom form renderer class itself, you just extend the Horde_Form_Renderer
class and override any methods that you want to alter, instead of necessarily
having to re-write the whole render() loop.

I've updated every occurrance of any of this code that I can find to take
advantage of this new architecture, and made a few minor tweaks while I
was at it. Also, some phpdoc comments for the custom renderer stuff.

Make the poll showing block work again, and clean up the poll summary block.

don't default to formatted menu, generate full menu parts and use them in the templates

Class name changes. Missed that module completely.

fix class name

- remove global $scry_template variable (helps avoid lots of scope problems)
- clean up blocks a bit
- shorten the polls summary display
- display better title in the poll block; still need to fix inlining and voting here.

- page titles
- message if there aren't any polls
- string consistency

- clean up vote checking
- allow a local scry admin

streamline the vote results view

since this file is used for blocks too, avoids the problem of returning  from a different form on the same page

- style
- use isVotable() and not hasVoted()
- error checking for invalid polls
- better error reporting when invalid poll and no poll available

check for isset of

set up this file for use when inlining, such as in horde blocks, clean up a lot the logic for displaying and processing the form, use  and SCRY_TEMPLATES

new horde_form syntax

use the new Form.php syntax for setting up variables

More useful results for polls, some cleanup.

get rid of unneeded extra params when rendering inactive, style

some style cleaning and use the Scry::getResultsGraph

use better naming scheme for the backend

add notify where missing and start putting in some proper standardised headers

the voting script