Revisions for scry/lib/Driver.php

Happy New Year

- check if poll is existing directly in getPoll()
- use count() for hasVoted inseted selecting data
- avoid some warnings

First optimization step reducing the number of queries and simplify query types:
- use just one simple query in getPolls() as retrieving polls ID separated is not needed and choices are retrieved by getVotes()
- track choice count on vote instead of having a join query to get the choices count
- cannot find any usage of poll_results_to so remove it
- use div and CSS insted of requesting the server for the pixel.php colored image
- add a dedicated and cached get poll function (getPoll still is called when lisitng polls several times for every poll)
- make getVotes() statis as we get them in the poll list then again later when chekig individual poll actions in isEditabe()
- remove settings the group permission. poll_group was droped last year so the cast to set the group permission never occurs
- use scry_voted cookie even to reduce DB access in hasVoted()

Permissions
- Avoid permission check overhead for common poll show/read task by do not set the permission of every poll as default permission on poll creation time. Create the default permission only when you actually pass to the permission editing form. Check the default permissions in the Scry::hasPermission function for non existing permissions.

Demographics
- Added demographics.php config file to define demographics groups
- Added hook to detect user demographics group belonging
- Add a drop down to which display between demographics groups in poll view

Others changes:
- spited read support in sql driver
- template -> view
- php5 constants and function definitions
- replace deprecated is_a with interface of
- autoload

Happy New Year

Assign copyright to The Horde Project for those copyright holders that already agreed to it.

* Standardized poll management links
* Changed $scry->isVotable() to accept a poll_id for API consistency
* Remove need to pass $votes to $scry->isEditable()
* Only allow group to be set on poll creation.  Further permissions editing will be done with a new UI

Only attempt to apply permissions on a new poll.  Existing polls have a separate
permission editor form.

* Change $scry->isOpen() to accept a poll_id for API consistency
* Properly check for editable polls

* Implement per-poll permissions
* Scry::isEditable() no longer returns true if the poll is closed
* Drop storage of the poll group in the SQL driver

ToDo: Allow existing polls' permissions to be edited by users with PERMS_EDIT.  Probably will reuse Perms_UI if possible.

Happy new year\!

References.

cannot

Use double-quotes.

Remove object keyword from phpdoc.

Fix viral 'wil' typo.

Remove "optional" from phpdoc.

Remove @version.

Happy New Year

Happy new year everyone.

need to count votes, not choices

make sure cookie exists first.

Don't re-fetch votes.

Add a check to see if a poll is open, that doesn't check identifiers.

these is_null calls were circumventing valid horde_form handling...

Add more poll state filters, and add tabs across the top of the poll list for switching
between open, all, closed, and disabled (only for admins) polls.

PHP 5 fixes.

Simplify driver instantiation even more.

fix setting of cookie

Let all driver based applications use Horde::getDriverConfig().

- clean up vote checking
- allow a local scry admin

minor style cleanups

should be false, and change the message to a generic denial

Remove var_dump().

Submitted by: Nuno Loureiro <nuno@co.sapo.pt>

better logic

- clean up, get rid of unneeded vars and functions
- change hasVoted() to isVotable() and check if voting withing time limits
- isEditable() check to stop editing of polls which have started voting already

Don't use call-time pass-by-reference.

- remove some unneeded functions
- add the parente savePoll() function
- clean up logVote()
- better error trapping/messages
- start the code to support different identifier methods
- clean up the hasVoted() logic

add the parent logVote() function

Nuke a lot of constants.php files.

Specific Reason: constants should be defined in the application's base
class file UNLESS constants are needed in one of the configuration
files (the case for all those remaining). Only then should you break
things out to a seperate file (and even then, we may want to just
include the app's library file).

General Reason: Including files is *very* expensive. Short files are
pointless if we can avoid them; it's much cheaper to have slightly
longer files than multiple short ones (especially when we're going to
include all the short files anyways).

add the variable to determine if a poll is editable or not

reshuffle the functions for setting/getting of current poll id

fix the displaying of voting/voting results

fix the fatal call

the libraries for the Scry app