Revisions for jonah/lib/Jonah.php

Fix return value, again. But add some salt of magic this time.

Tags: JONAH_2008_08_22

* Make sure the perms tree is properly constructed so we can populate all branches
* Make sure that Jonah::checkPermission returns true if the user is an administrator and there are no channel IDs specified

Fix return type.

put New Story in the menu bar like in other horde apps; get rid of the unused
tabset. Also give the "N" accesskey to New Story, since that should be much more
common than creating a new feed.

Consistent perms checking. Don't show links that the user isn't authorized
for. Let users with delete permissions to a channel delete stories from that
channel.

remove jonah-specific proxy config; just rely on the global Horde one

It makes more sense IMO to keep the news ordered by publish date than update date.

remove vague todo

First stab at supporting ordering story lists by read count (comment count still to come).  Obviously for internal channels only.
Also new block that displays stories ordered by read count.

Thoughts / Comments / 'What the heck were you thinking' welcome.

Just the !empty check should be sufficient here.

Use the Horde-level proxy setting if it's there.

[cjh] Detect charset information from XML prologue as well as the
Content-Type header (s_gatterbauer@idlm.net, Bug #4340).

Nice, the php xml parser it not able to detect the charset from the 'encoding' attribute. Charset conversion in Jonah only used to work because the UI accidentally had the same charset like the displayed feeds for most users.

update menu

Consistent terminology and some tweaks.

[cjh] Use Horde_Block_Layout_View for the My News page.

[cjh] Add jonah:admin permission (tevans@tachometry.com, Bug #2571).
[cjh] Add internal template type for internal stories (tevans@tachometry.com,
Bug #2571).

array_shift() needs a variable.

Lots of little updates. Re-use html delivery page instead of
JONAH_SHOW_CHANNEL code. Have an alternate RSS link on the HTML
delivery page. Hopefully more intuitive names for kinds of
channels. HTML cleanups.

"@access public" is redundant.
Wrapping.
Use proper types in phpdoc.
Specify "@access private" correctly in phpdoc.

- html cleanup
- don't instantiate $template variable in base.php
- menu item cleanups and accesskeys
- lots of htmlspecialchars fixes

Clean up phpdoc for constants.

yet another menu fix

this should nail down the menu selection logic

Small HTML cleanup, use menuSpacer, and show My Content as selected on
index.php.

New menu.

Bug: 832

first lot being moved from gif to png

change getParam('graphics') to getImageDir()

Composite channels.

Don't show My Content in menu for guest, redirect guests to delivery page.

Add support for aggregated channels, like "Planet [insert your favourite project here]".

Simplify a bit.

Add proxy support.

No more HORDE_LIBS.

not needed now, prefs ui can now deal with menu arrays

seems like prefs still uses this, put patch it for now, but prefs should be able to handle an array menu being returned to it too?

add functions to fetch body types and to figure out a default body type

menu.inc template no longer needed

shorten menu item

change admin path to point to channels

add menu

move Menu.php to a framework package.

do some checking of the previous level in perms

clean up a bit, add a function to map between channel type and perm name

add a function to check permissions

Remove stocks code from Jonah - it's moving to Juno.

Remove the last of the weather code from Jonah.

Show notifications only from the requested message stack.

Move Horde_Serialize to framework.
Remove gettext dependancy.

center the chart graphic

cleaner stocks list

Show total portfolio value and delta (Guil Barros <listmail@metathusalan.com>)

unneeded constants, comments

Use the new Util:: class.

Simplify driver instantiation even more.

Use new getDriverConfig() syntax and make sure that Horde's settings are
really used.

Allow any number of days in the forecast (e.g. 7-day forecast instead
of 5-day forecast)

Fix section balancing in conf.xml

* Make the weather site a driver configuration option
* Add a second driver for ejse weather service (not very good yet).
* In order to use the ejse driver, you'll need a new weather.php or new
sql database, not yet included...

fix column order.

Play around with some UI tweaks. Forms automatically get alternating
row colors now.

Add stock charts. There are a lot of options that the UI doesn't make use of yet,
and the backend could be smarter about putting them together. But it's there,
and it works.

fix typo

Submitted by: Leena Heino <Leena.Heino@uta.fi>

Tweaks to the weather HTML, cleaner HTML (table nesting) in many
cases, match up tags, make the content display a bit nicer overall.

Optionally track a number of shares for a stock, and present the current value.

Indexes are back.

- Nuke arrows on second thought
- use spans instead of font color=

- Update for new weather code
- remove functions that aren't needed anymore.

Use the Yahoo driver by default. The Nasdaq driver works just fine, but
HTTP_Request doesn't seem to be handle the &symbol=a&symbol=b format
we need to fetch multiple quotes at once. Haven't had a chance to try and
figure out why, though.

Price change direction graphics

restore alternating row colors

- remove code that isn't needed now
- update for new Stocks api

- Inherit from new Jonah_Stocks:: base class
- Use Jonah_Stocks::singleton() for instantiation
- deprecate now unused getCachedFP() function.

phpdoc

Better (working) regexp (Joe Wilson <joe.wilson@mindcandy.org>).

- array_key_exists() -> isset()
- gettext
- much nicer/cleaner stock display, both list and detail view.

Silence socket errors.

Strip out potential bad data in XML.

Submitted by: Sander Dalemans <sander@gamerszone.nl>

Remove index stocks until someone can explain how to get XML for them
again.

better error reporting

Horde::addParameter() syntax

Another batch of menu.php -> ::menu() changes.

use single quotes

Use HTTP_Request in Jonah::_readUrl() so that we can timeout more
easily. Consolidate other url-fetching code so we always use
Jonah::_readUrl().

- style
- fix PHPdoc
- remove unused class var.

use the smallheader

Better error checking, consistent HTML.

Exit fatally if Cache backend can't be created (good idea?)

cleaning up

Remove news-specific functions from here and move the to the Jonah_News class.

the main changes in this lib:
- start moving jonah libs to separate classes/objects for news, weather and stocks, to allow for more flexibility and cleaner scripts.
- subscribed channels now use a generic prefEncode()/prefDecode() to be saved into the preferences backend using serialization/utf7, cleans up a bit of code and allows for more parameters to eventually be passed when subscribing to channels.
- NOTE: if you want to save your previous channel subscriptions there's a script: /jonah/scripts/prefchannels_b64_serialize.php which attempts to convert from the old base64 to the new serialized format.
- functions channelPrefEncode() and channelPrefDecode() have been removed.

Much neater forecast display.

Submitted by: Jeff Graves <jeff@image-src.com>

Better error checking in a number of places for channels which no longer exist.

Nuke a lot of constants.php files.

Specific Reason: constants should be defined in the application's base
class file UNLESS constants are needed in one of the configuration
files (the case for all those remaining). Only then should you break
things out to a seperate file (and even then, we may want to just
include the app's library file).

General Reason: Including files is *very* expensive. Short files are
pointless if we can avoid them; it's much cheaper to have slightly
longer files than multiple short ones (especially when we're going to
include all the short files anyways).

Weather cleanups, use HTTP_Request to fetch weather, with a timeout of
5 seconds.

- Move Cache_session to Horde_SessionObjects - the semantics just
aren't the same as the rest of the Cache drivers.

- Rename Cache:: to Horde_Cache:: for consistency/packaging.

- The Horde_Cache:: API is completely revamped to be more
flexible/easy to use.

- Add Horde_Cache_zps::, which lets you use the Zend Performance Suite
output cache as your caching backend.

Remove some unneeded prefs, a couple unneeded functions, clean up
HTML, etc.

Add a weather block for the intercept weather.

Submitted by: Rick Emery <rick@emery.homelinux.net>

- Start getting stock quotes code into one code tree
- remove unneeded old Block.php
- add stocks block to new Block api
- remove portal code, not needed anymore.

Make sure the conf array is available

Clean up some of the Jonah portal code; getting close to this being
ready for real Horde use.

the Headlines block no longer uses a completely different set of code
than the standard My Content headlines.

More Horde-like HTML.

- clean up channel HTML (consistent widths)
- fix up/improve templates (show story descriptions in detailed &
standards views)
- show channel name instead of key in one more place.