Revisions for imp/search.php

Remove javascript files that live in Horde proper.

Bug: 6921
MFH:
1.1162    +1 -0      imp/docs/CHANGES
1.116     +39 -17    imp/lib/Search.php
2.199     +21 -2     imp/search.php
1.31      +2 -0      imp/templates/search/search.html

Tags: IMP_4_3, IMP_4_3_RC2, IMP_4_2_1_RC1

Bug: 6921
Search by size now displayed in KB.
Also, doesn't make sense to have 'not' searches for Size searches.

Bug: 6825
MFH: Improve search page by moving flags into search criteria section.

Bug: 6825
Automatically update old virtual folders to new internal format.

Bug: 6825
Merge after: 1 week
Improve search page by moving flags into search criteria section.

MFH: Add ability to search by size.

MFH: 2.196

Tags: IMP_4_2

We can't use Horde::label() here because it removes access keys,
a.k.a. underlines unconditionally.
Bug: 6745

Add ability to search by size. Extend IMAP_Search:: to use MessageCache
information when doing the size search (merge to IMP 4.2.1).

MFH: 2.194

Tags: IMP_4_2_RC4

Link back to folder.

MFH: 2.193

Use delete icon on search page for removing criteria.

Bug: 6515
Submitted by: Liam Hoekenga <liamr@umich.edu>

Happy New Year

Tags: IMP_4_2_RC3, IMP_4_2_RC2

Happy New Year

Merge from HEAD.

Do a smarter job of loading some libraries - we pretty much will always need
IMAP.php, while Template/Help is only needed when viewing via imp (they
are not needed when using dimp/mimp).

Tags: BEFORE_MERGE_3_2, IMP_4_2_RC1

I removed too much. Fix editing search fields.

Bug: 5856

This always annoyed me: remove default search field preference and show all common fields instead.

Jon has assigned his copyrights to The Horde Project.

Tags: IMP_4_2_ALPHA

Bump year, looks like a missed a few last time.

Bug: 5307
Inline PHP-generated javascript to avoid cross-domain leaking.

MFB: Escape variables.

Look for js.php files in the right place.

Bug: 4867
[mms] Change 'Important' flag to 'Flagged For Followup' and clear the flag
after a reply (Request #4867).

Improvements to addInlineScript() usage.

Happy New Year

Tags: IMP_4_1_6, IMP_4_1_5, IMP_4_1_4, IMP_4_1_4_RC1

Happy New Year

Assign copyright to The Horde Project for those copyright holders that already agreed to it.

Remove PHP code from search JS file.

- Load template engine in base.php since it's used pretty much everywhere.
- Use IMP_Template everywhere, not Horde_Template
- No reason to use Template/Template.php, just use lib/Template.php.

No need for if flag in templates anymore

Convert to prototype

coding standards: don't use is_null().

Fix date picker.
Element id attributes cannot contain '[' or ']'.

Bug: 4171

Bug: 4065
Add folder size display to folders page.

Refactor code so Auth_imp:: only deals with authenticating to the IMAP server.
Auth_imp no longer automatically opens a connection to the current mailbox. We
must now manually call IMP_IMAP::changeMbox() anytime we are working with the
IMAP stream and require a connection to a mailbox.  Much cleaner, and should
eliminate any issues with clearing the 'recent' flag incorrectly.

No need to have a separate "Edit search query" view since this is what we
always do for non Virtual Folder editing.  Just populate the fields and act
like we are doing a regular query creation.

Bug: 3897
MFH 2.170

Tags: IMP_4_1_3, IMP_4_1_2

Bug: 3897
Don't use references here.

The invisible commit: remove stray whitespace at end of line.

Remove deprecated assign by reference for new object instantiations.

MFH: Tree.php - 1.101; IMP.php - 1.558; Search.php - 1.81; Session.php - 1.124;
mailbox.php - 2.752; search.php - 2.167

Use IMP_Search::createSearchID() to create canonical query ID, for consistency
sake.
In case a VFolder ID becomes invalid and it is set as the initial_page, default
to INBOX and set the pref to the default INBOX value.

MFH 2.166

$search should never be empty, but if it is, default to values that won't leave
us with a bunch of undefined errors.

Use more generic labels for date search criteria (Bug #3448).
HTML cleanup, get rid of a bunch of borders around form elements, especially in IE.

standardize my e-mail address

Bug: 3337
Initial implementation of "recent search" caching/retrieval.

MFH: Allow searching with POP servers again.

Tags: IMP_4_1_1, IMP_4_1

no longer needed

There's no reason we shouldn't allow searching with POP.  Thus fix new
search code to allow us to search INBOX with POP servers.

Add IMP_JAVASCRIPT constant.

Move all javascript specific files to templates/javascript/src.  Allows us to
1) compress JS code, 2) keep javascript files separate from presentation
files.
Add header comments to all JS files.

Looks like IMP_IMAP_Search didn't get added correctly last time (due to my
cvs ineptness).  Add it and make sure we use it everywhere.

Tags: IMP_4_1_RC3, IMP_4_1_RC2

Add IMP_IMAP_Search_Query:: in order to work around BC-breaking bug.
Fix variable in lib/Mailbox.php that broke message lists.

Apparently you can use gettext tags inside an HTML tag.  I don't know why I
thought otherwise.

MFH: Add ability to edit search queries.

MFH: create_vfolder not used (really commit it this time)

MFH: 'create_vfolder' not used

the 'create_vfolder' case is never used.

MFH: Fix template error

Fix template error

logic flip

* Another typo

* fix typo

MFH: 2.153 (partial)

remove unused template variable
Don't get too fancy - just use 'Inbox' as the default search.

MFH: New IMP_Search:: framework.  Since HEAD and FRAMEWORK_3 are significantly
different in lots of areas, I had to do quite a bit of manual merging -
hopefully I got everything.

small tweak

Various fixes/enhancements/tweaks for the IMP_Search:: code.

Fix parameters passed in when creating virtual folder.
Fix message returned after creating virtual folder.

Bug: 3255
Merge after: 1 week
Rewrite of IMP_Search:: and IMP_VFolder::.  We shouldn't need a separate
vfolder library as the vfolder stuff is simply a subset of our searching
code.
Problems with old code: It was impossible to know for sure whether we were
currently in a virtual mailbox vs. just a search mailbox since there was
no location we could reliably check for this.  Now, IMP_Search does all the
work for us - $imp_search will always be available and global if we are using
IMAP.
I realize this is a lot of changes during the RC phase, but necessary since
there were multiple bugs/issues I have found that could not be fixed without
this change (e.g. Bug 3255).  I'm going to give this a few days of testing in
HEAD before I merge so dont expect it in 4.1 immediately.

Clean up some html formatting.  Use IMP_Template:: to workaround
Horde_Template BC limitations (ifs in nested loops).

Convert menu generation to Horde_Template - is now output by calling
IMP::menu().

build these widgets in the template, not the script.
only load IMP_Folder:: if needed.
Fix undefined variable error.

Fix 'not' handling.

Convert search page to Horde_Template::.

Happy new year

Tags: IMP_4_1_RC1

Happy new year\!

@define

MFH: cannot

cannot

Merged from HEAD

Bug: 2650
Added preference to define the default search field.

Tags: BEFORE_MERGE_3_1

MFH: fields.inc - 1.17; CHANGES - 1.832; search.php - 2.139

Tags: IMP_4_0_5, IMP_4_0_4, IMP_4_0_4_RC2

Add entire message search to search page.

Bug:
Submitted by:
Merge after:
Removed 'folders', 'namespace, and 'hierarchies' parameters.
Additionally, use correct delimiter depending on the current namespace (since
each namespace can have a different delimiter).

PLEASE NOTE: THIS COMMIT CHANGES A *LOT* OF CODE - code that has been in
IMP for years and has been tweaked until it works on 99.9% of the systems.  The
new code, when fully debugged, is much better in that it conforms to RFC 2342
and removes the confusing 'namespace', 'hierarchies', and 'folders' parameters.
However, especially with systems that use a non-blank personal namespace, this
code is woefully untested at this point.  If you value having a system that
may be able to work the next few days, DO NOT UPDATE FROM CVS.

This commit does not address issues with IMAP_Tree and namespaces either.  I
want to stabilize this code first before I tackle that issue.  There are
serious BC issues to be resolved with fixing/upgrading that code...

Finally, this change will most likely render all mailbox preferences/identity prefs that are currently storing a mailbox value invalid.  This is because the
old way we stored these values (without the namespace information tacked onto
the front) is no longer valid in IMP since there is no more concept of a
"default" namespace.  I will probably have to work on an upgrade script that
will automatically preface all mailbox values in prefs with either a user
specified string or with the value of the default namespace.

Please track bugs at http://bugs.horde.org/ticket/?id=2422

space for clarity

MFH: Remove unneeded "@access public".
Wrapping.

Tags: IMP_4_0_4_RC1

Remove unneeded "@access public".
Wrapping.

MFH: Remove "optional" from phpdoc.

Remove "optional" from phpdoc.

[jan] Improve rendering for right-to-left languages, add right-to-left
specific theme (Amirkabir MetaNET Ltd.).

Fix parse error.
Submitted by: Rick Emery <rick@emery.homelinux.net>

Make sure special Virtual Folders can never be edited.

MFH: search.php - 2.131; CHANGES - 1.719

Tags: IMP_4_0_3, IMP_4_0_3_RC1, IMP_4_0_2, IMP_4_0_2_RC1

Make sure we show "container" folders in the folder list.

Bug: 1160
MFH: search.php - 2.130; CHANGES - 1.716

Bug: 1160
Require virtual folders to have a label.

Happy New Year