Revisions for imp/pgp.php

MFH: 2.121

MFH: 2.120

Don't allow adding private keys as public keys.
Bug: 7080

Re-order to easier follow the logic.

MFH 2.119

Tags: IMP_4_2, IMP_4_2_RC4

don't re-define IMP_BASE when this is included from prefs.php

MFH: Start updating app pref handlers to correctly work with DIMP.

Start updating app pref handlers to correctly work with DIMP.

Bug: 6280
MFH: Fixes re: popup JS code

Tags: IMP_4_2_RC3

Make sure prototypejs is loaded when we call popup code.

MFH:
1.1083    +2 -0      imp/docs/CHANGES
2.34      +6 -6      imp/filterprefs.php
2.116     +5 -5      imp/pgp.php
2.84      +3 -3      imp/smime.php

[cjh] Make sure that custom checkbox preferences are stored as 0 or 1 instead
of 'on' or ''.

Happy New Year

Tags: IMP_4_2_RC2

Happy New Year

Merge from HEAD.

Do a smarter job of loading some libraries - we pretty much will always need
IMAP.php, while Template/Help is only needed when viewing via imp (they
are not needed when using dimp/mimp).

Tags: BEFORE_MERGE_3_2, IMP_4_2_RC1

Typo in error message.

Don't search key servers when adding public pgp keys to the address book.
Search key severs as the final resort only, i.e. after checking the user's
identity.

Bug: 5307
Inline PHP-generated javascript to avoid cross-domain leaking.

Tags: IMP_4_2_ALPHA

Find imp.js.php in the correct place.

Happy New Year

Tags: IMP_4_1_6, IMP_4_1_5, IMP_4_1_4, IMP_4_1_4_RC1

Happy New Year

Assign copyright to The Horde Project for those copyright holders that already agreed to it.

Remove PHP code from popup.js.

- Load template engine in base.php since it's used pretty much everywhere.
- Use IMP_Template everywhere, not Horde_Template
- No reason to use Template/Template.php, just use lib/Template.php.

No need for if flag in templates anymore

Bug: 4253
More encoding improvements for popup_imp().

Bug: 4253
encode parameters properly

Bug: 4022
Add preference to only verify PGP & S/MIME signed data upon user request.

Vhost'ed preference files.

Add support for symmetric PGP encryption.

No more global $imp variable.  Just use $_SESSION['imp'].

Refactor code so Auth_imp:: only deals with authenticating to the IMAP server.
Auth_imp no longer automatically opens a connection to the current mailbox. We
must now manually call IMP_IMAP::changeMbox() anytime we are working with the
IMAP stream and require a connection to a mailbox.  Much cleaner, and should
eliminate any issues with clearing the 'recent' flag incorrectly.

Remove deprecated assign by reference for new object instantiations.

MFH: Never open connection to specific mailbox unless we need it.

Tags: IMP_4_1_3, IMP_4_1_2, IMP_4_1_1

Unless we explicitly set the OP_HALFOPEN flag, imap will default to INBOX.
Automatically convert a blank mailbox to OP_HALFOPEN in IMP_IMAP so we can
more accurately track the current stream state.
Don't open a mailbox if the page has explicitly said we do not need a
connection to a mailbox (e.g. OP_HALFOPEN).
Add some more pages to the list of pages that don't need an active mailbox.

standardize my e-mail address

Don't need these calls anymore as this was fixed in the correct place.

We need to immediately save these prefs values because we may access some
code (i.e. registry call) that will overwrite the prefs for the remainder of
the page load with the old values.

action not needed anymore

Finish converting PGP scripts to Horde_Template::

MFH: We should only need one javascript file to open these popups.

Tags: IMP_4_1, IMP_4_1_RC3

We should only need one javascript file to open these popups.

Convert passphrase input to Horde_Template::.

Apparently you can use gettext tags inside an HTML tag.  I don't know why I
thought otherwise.

convert to Horde_Template::

Move these script files to javascript/ so we can call Horde::addScriptFile()
to include them.

Happy new year

Tags: IMP_4_1_RC2, IMP_4_1_RC1

Happy new year\!

MFH: fread() -> file_get_contents()

More fread() -> file_get_contents().

MFH: cannot

cannot

Bug: 2797
MFH: pgp.php - 2.82; smime.php - 2.51

Bug: 2797
This JS is not necessary since we already focus elsewhere, and it is not
triggered/displayed until the compose window is loaded anyway.

Merged from HEAD

Cleanup PGP preferences, get rid of tables, use Prefs_UI elements.

Tags: BEFORE_MERGE_3_1

Happy New Year

Happy New Year

Tags: IMP_4_0_5, IMP_4_0_4, IMP_4_0_4_RC2, IMP_4_0_4_RC1, IMP_4_0_3, IMP_4_0_3_RC1, IMP_4_0_2, IMP_4_0_2_RC1, IMP_4_0_1

$GLOBALS cleanups.

Tags: FRAMEWORK_3, IMP_4_0, IMP_4_0_RC3, IMP_4_0_RC2

New menu.

Tags: IMP_4_0_RC1

Remove debug code.

Tags: IMP_4_0_BETA

Registry::getParam() -> Registry::get().

Try to do better checking to make sure imported personal public and private
keys are correct.
Try to make the text a bit clearer on the import page.
Some formatting tweaks on the import page.

Clean up some of the code dealing with importing personal keys and add some
comments.

Use fopen/fread instead of file().

Move allowFileUploads() and wasFileUploaded() from Horde:: to Browser::

No more HORDE_LIBS.

Remove Server.php; all functionality has migrated elsewhere. It may not all be in its final home, but we'll see.

Tags: IMP_4_0_ALPHA

Use javascript notification instead of $js_onLoad.

All footers look the same, so why not use only one.

Prefs moved to framework

Happy new year everyone.

We shouldn't need these anymore now that js_onLoad is obtained through
Util::nonInputVar().

Move classes that extend Horde libraries to subdirectories.

Move Horde_MIME to framework.  If I somehow managed to convert all includes to
the new path, I owe myself a beer.

Move Horde_SessionObjects to framework.

PrefsUI.php is now Prefs/UI.php for better packaging/etc. More work on this
may follow later. Now it's pie-baking time.

Use the new Util:: class.

Convert from numeric -> string Action IDs.
If this works out, we can do this with the other Horde apps as well.

Nuke status.php - 1 less pageload - and move to IMP::status().
This can be done for all other Horde applications also (e.g. like what
Chuck did for menu.php).  I'll slowly try to do this, but any help would
be cool also :)

Push the whole PEAR_Error on the notification stack.

Nuke menu.php - one less file included on every page load.

Use pgpPrettyKey() when viewing a key and in the mime viewer. This is much
more informative than showing the PGP data block.

[cjh] Add navigation for previous/next preferences block in PrefsUI
(Mathieu CLABAUT <mathieu.clabaut@free.fr>).

Submitted by: Mathieu CLABAUT <mathieu.clabaut@free.fr>

- Move Cache_session to Horde_SessionObjects - the semantics just
aren't the same as the rest of the Cache drivers.

- Rename Cache:: to Horde_Cache:: for consistency/packaging.

- The Horde_Cache:: API is completely revamped to be more
flexible/easy to use.

- Add Horde_Cache_zps::, which lets you use the Zend Performance Suite
output cache as your caching backend.

Set charset in _textWindowOutput()

Submitted by: Chris Hastie <lists@oak-wood.co.uk>
Improved handling of PGP packet information.
PEAR::isError -> is_a().
No need to number any of the file pointer variables.

Fix warnings.

Separate the two import steps a bit clearer.

Bump year.

Add blurb on requirement of popup windows.
is_a(), addParameter() updates.

Fix and cleanup saving of PGP public keys.

The getCode() here doesn't return a valid notification status, so
users were getting a blank passphrase window with no apparent
errors. Now they actually get to see what's wrong.

Fairly huge commit, due to the amount of code I could rip out with
this change (yay, fewer lines, same functionality):

[cjh] The mail/compose method is now a full call, not a link. This means,
      aside from a bit less code duplication, that we now honor the
      compose_popup preference in $registry calls.
[cjh] Deprecated Registry::includeFiles() and Registry::shutdown().

Only need to output javascript code once.

IMP_PGP:: now extends Horde_Crypt_pgp::.
Move all MIME_Part PGP generation to Horde_Crypt_pgp:: so that it can be
used by all Horde applications.

Improved file upload checking (uses Server::wasFileUploaded() now).
$imp['file_uploads'] now contains the maximum upload size in bytes.
Cleanups in folders.php.

Use Horde::closeWindowJS().

Match module name with registry entry.

cleanup; fix enabling of S/MIME, don't show S/MIME prefs if openssl
isn't available (saves the user from an ugly fatal error screen).

Call IMP::checkAuthentication once in lib/base.php instead of in each page.