Revisions for imp/lib/Folder.php

Add a condensed version of Horde_Imap_Client:: for now so that we can remove
Horde_Imap_Client from CVS.

More merges from my private dev branch.

Point to new location of removeBareNewlines().

Second parameter doesn't do anything and no need to return reference.

small tweak.

Bug: 7157
MFH:
1.222     +11 -19    imp/lib/Folder.php
1.203     +36 -10    imp/lib/IMAP/Tree.php

Tags: IMP_4_3, IMP_4_3_RC2

Bug: 7157
Add parameter to IMP_Tree::folderList() to allow obtaining a partial folder
list.  Use this partial folder list in IMP_Folder::rename().
Make sure to add the original renamed folder to the list of deleted folders
in rename().

IMP_MailboxCache -> IMP_MessageCache.

Tags: IMP_4_2_1_RC1, IMP_4_2, IMP_4_2_RC4, IMP_4_2_RC3

This has bothered me for the longest time - we are storing messages in this
cache, not mailboxes.  Change the library name now and corresponding config
options so we don't need to change them after 4.2 is released.

Happy New Year

Tags: IMP_4_2_RC2

Happy New Year

MFH 1.219

Same update code used in both rename() and delete() - abstract out so we
ensure that we are always doing the necessary updating in both places (e.g.
we were missing a step in rename() previously).

Merge from HEAD.

On second thought, only show notification for original folder rename -
showing notification for all subfolders may result in thousands of
notification messages.

Tags: BEFORE_MERGE_3_2, IMP_4_2_RC1

Bug: 5764
Upon re-reading of RFC, IMAP servers *MUST* rename all child folders if the
parent folder is renamed.  Thus, don't even attempt to hack around this
problem - if the IMAP server doesn't rename child folders, then it is
totally broken.
Additionally, caught two instances of calling expireCache() where we were
not passing in the mailbox name.

Looks like imap_status(), on some servers, will kill the IMAP stream if the
mailbox does not exist.  Stupid c-client.  Thus, we need to do this check
another way.

Short circuit fixed folders test if it is not defined.

Allow maintenance tasks to rename and delete fixed folders (Bug #5592).

Jon has assigned his copyrights to The Horde Project.

Tags: IMP_4_2_ALPHA

MFH: [cjh] Lower memory usage when downloading folders
(Andrew Morgan <morgan@orst.edu>).

Tags: IMP_4_1_6, IMP_4_1_5

[cjh] Lower memory usage when downloading folders
(Andrew Morgan <morgan@orst.edu>).

Bump year, looks like a missed a few last time.

Add configuration for folders that may not be modified.

Cleaner rename algorithm that avoids a preg_replace() call.

Use our own set of IMAP flags to not unnecessarily reopen mailboxes.

Use unaliased keys to access imap tree elements.

Happy New Year

Tags: IMP_4_1_4, IMP_4_1_4_RC1

Happy New Year

Assign copyright to The Horde Project for those copyright holders that already agreed to it.

Standardize copyright wrapping and spacing.

MFH: CHANGES - 1.993; Folder.php - 1.203

Always subscribe to created folders.

Always unsubscribe from folder when deleting, even if subscriptions is not
currently on.

no need to rebuild VF list during a session.

MFH: catch empty folder names.
Bug: 4380

Catch empty folder names in several places.

coding standards: don't use is_null().

Bug: 4245
Make sure all folder caches are emptied when we rebuild the folder tree.

Bug: 4234
Fix subscriptions when renaming.
Change current mailbox if current mailbox is renamed.

Tags: IMP_4_1_3

Add IMP::removeBareNewlines().

Bug: 4015
MFH 1.196

Tags: IMP_4_1_2

Bug: 4015
Correctly compare folder names without the server prefix.

Remove 'stream' as a session variable.  it is nothing more than a disguised
global since it doesn't persist between page accesses.
Don't require us to pass the imap stream to several overriden functions since
we can do the necessary stream passing in the overriden functions themselves.

Most likely more efficient to just use an imap_status() call here, not to
mention it prevents us from keeping cached information in two places.
Make sure we expire folder cache information when folders are deleted.

Refactor code so Auth_imp:: only deals with authenticating to the IMAP server.
Auth_imp no longer automatically opens a connection to the current mailbox. We
must now manually call IMP_IMAP::changeMbox() anytime we are working with the
IMAP stream and require a connection to a mailbox.  Much cleaner, and should
eliminate any issues with clearing the 'recent' flag incorrectly.

Remove unneeded @since entries and fix a few others.

Fix parenthesis.

cache values correctly again.

Remove debug code.

Simplify this code a *ton* by simply using the cached values from IMAP_Tree.
Should enable us to only have to call imap_list()/imap_lsub() once per
level/per login.

Remove deprecated assign by reference for new object instantiations.

Bug: 3557
MFH 1.186

Tags: IMP_4_1_1

Bug: 3557
Fix for inconsistent IMAP wildcard behavior.

we need to pass a single mailbox name in to setSort(), not an array.

MFH: 1.184

Only subscribe to folders if necessary.

Bug: 1483
Allow user to save per-folder sort preferences.

MFH: 1.182

Tags: IMP_4_1

Looks like Thunderbird/Seamonkey doesn't export sender address with mbox files.

MFH 1.181

a container != a folder.

MFH 1.180

more folder list fixes

MFH: Folder.php - 1.178, 1.179; Client.php - 1.37;
rename_sentmail_monthly.php - 1.34

Speed up IMP_Folder::exists() by checking IMP_Tree:: before doing a server
query.
Fix parsing the results of that server query.
Remove second parameter to exists.  Correctly update exists() cache internally
instead.

Several fixes dealing with correctly showing folders in hidden namespaces.
Slightly faster performance when creating folder lists as we only access the
server once for all known namespaces combined (instead of once each).
Fix IMP_Folder::exists() - as far as I can tell, it was always returning false.

MFH 1.177

Bug: 3342
Fix folder list display at last (I hope).

MFH: Folder.php - 1.175, 1.176; Sort.php - 1.1

Track changes to IMAP_Sort::.

Fix display of folders in personal (non-empty) namespaces.
Add IMP_IMAP_Sort:: to work around BC breaking issue in IMAP_Sort::.

MFH 1.174

simplify code

Bug: 3342
MFH 1.173

Bug: 3342
Clean up folder generation code.  hopefully this fixes any errors with
misplaced container elements.

MFH: Folder.php - 1.172; Tree.php - 1.83, 1.84

Tags: IMP_4_1_RC3, IMP_4_1_RC2

We need a way to indicate what IMAP_Tree object we want the program to update
globally since IMAP_Tree is called all over the place.  Therefore, revert
the IMP_Folder changes and instead define a global variable that can be
used to specify IMAP_Tree init parameters.

MFB: Don't load IMP_Tree unless needed.

MFH 1.170

Allow us to use an external IMAP_Tree object for folder changes (needed for
dimp).

MFH: Tree.php - 1.79; Folder.php - 1.169

Add IMP_Tree::rename().
Fixes bug when renaming - keep polled state for new folder.

MFH 1.168

unneeded bit of logic

Bug: 3307
MFH: flag() is the exclusive way we should set the seen flag.

MFH: New IMP_Search:: framework.  Since HEAD and FRAMEWORK_3 are significantly
different in lots of areas, I had to do quite a bit of manual merging -
hopefully I got everything.

Bug: 3255
Merge after: 1 week
Rewrite of IMP_Search:: and IMP_VFolder::.  We shouldn't need a separate
vfolder library as the vfolder stuff is simply a subset of our searching
code.
Problems with old code: It was impossible to know for sure whether we were
currently in a virtual mailbox vs. just a search mailbox since there was
no location we could reliably check for this.  Now, IMP_Search does all the
work for us - $imp_search will always be available and global if we are using
IMAP.
I realize this is a lot of changes during the RC phase, but necessary since
there were multiple bugs/issues I have found that could not be fixed without
this change (e.g. Bug 3255).  I'm going to give this a few days of testing in
HEAD before I merge so dont expect it in 4.1 immediately.

Happy new year

Tags: IMP_4_1_RC1

Happy new year\!

MFH: Remove 'dotfiles' server parameter.

Remove 'dotfiles' server parameter.

MFH 1.164

copy/paste error

Bug: 3019
MFH 1.163

Bug: 3019
Don't try to split a mailbox name if there is no delimiter.

MFH 1.162

remove some unneeded variables

Bug: 3019
I am dumbfounded as to why this does not throw a warning on my system, even
with E_ALL on.  This index simply does not exist.  (Although I wonder if this
has to do with the $foo{} -> $foo[] switches in the PHP core).

Delete mailboxes from the cache when they are renamed or deleted.

Never set the 'seen' flag unless we explicitly call flag() (i.e. don't let
imap_body() or imap_fetchbody() automatically do it for us).

MFH: 1.158