Revisions for imp/lib/Compose.php

MFH 1.403

Don't attach PGP public key twice.

Add a condensed version of Horde_Imap_Client:: for now so that we can remove
Horde_Imap_Client from CVS.

Bug: 7641
For now, don't strip blob information from subjects.

Use MIME:: functions, not IMP_Compose:: functions.

Change parseMIMEHeaders() -> parseHeaders().

Pass mailbox into function, not server string.

More cleanup picked out of the 1000's of lines of code I have already changed
in IMP due to the IMAP/MIME rewrite.
Removing ability to change server parameters on the login
screen  All sorts of issues here (code-wise and security wise).  For now,
servers need to be configured in servers.php period.

More merges from my private dev branch.

Point to new location of removeBareNewlines().

Move several functions to framework libs.

Strip extra 'Fwd' and 'Re' cruft from subject line when replying to or
forwarding a message.

Remove deprecated functions from MIME_Headers::.
Move parseMIMEHeaders() from MIME_Structure:: to MIME_Headers::.

MFH:
1.391     +2 -2      imp/lib/Compose.php
1.40      +3 -3      imp/lib/IMAP/Cache.php
1.22      +3 -3      imp/lib/IMAP/MessageCache.php
1.29      +2 -2      imp/lib/UI/Compose.php

Some places where we should be using 'uniquser' instead of 'user'.

Bug: 7427
Don't need this sanity check here, and it breaks searching with spaces.

No longer needed.

MFH: 1.388

Tags: IMP_4_3

Grammar

Cleanups on some missed items from the removal of IMP_IMAP_Search.

MFH: 1.386

Catch and log if sent-mail logging has been disabled.
Bug: 7331

MFH 1.385

Tags: IMP_4_3_RC2

Close format string correctly.

Submitted by: acmpires@gmail.com

MFH 1.384

Submitted by: acmpires@sapo.pt
Fix gettext.

Bug: 7261
Fix incorrect MFH 1.382

MFH: 1.383

MFH: 1.382

No reason to silence those.

Catch empty search results.

Bug: 7215
2.424     +4 -3      imp/folders.php
1.381     +7 -6      imp/lib/Compose.php
1.1172    +1 -0      imp/docs/CHANGES

Bug: 7215
Run uploaded filename through Util::dispelMagicQuotes().

MFH: Make rfc2822Encode() a public method.

Make rfc2822Encode() a public method.

Parser is not used anymore here.

If we are using IMP as the auth handler, no need to have duplicate, identical
'imp_key' and 'auth_key' cookies.  Saves ~40B on each request which may not
seem like much but every little bit helps.

The expand code uses assumptions left over from the time when we had to do
expanding on refresh (i.e. expanding more than one field at a time). Greatly
simplify code by implementing 1 search string per call, and always return
results in an array. Failure in expansion is another thing that doesn't
need to be reported to the user (bad data should simply be ignored in this
case), so simplify error handling also.

Bug: 7110
MFH 1.376

Tags: IMP_4_2_1_RC1

Bug: 7110
Don't add ',' to end of addresses in address list.

Break out expandAddress() into 3 separate functions - 1 for expanding a
string, 1 for generically listing all addresses in the sources, and 1 for
generating the source-related prefs values.  The 3rd func can be used on
the prefs page (eliminates duplicate code).  Also, do a bunch of minifying
of complete unnecessary long DOM strings while I am in here.
The 2nd func will be used for non-AJAX address expansion on the compose page -
I currently have a working prototype using Autocompleter.Local, but it still
needs to be tweaked a bit.  With the Autocompleter.Local option, you can only
search a "Name <email>" sring.  Unfortunately, I have to figure out how to deal
with a pref value of search_fields other than "name\temail", although for the
life of me I can't really figure out what other fields you would want to
search here.

MFH:
1.1165    +1 -0      imp/docs/CHANGES
1.374     +9 -21     imp/lib/Compose.php
1.26      +12 -4     imp/lib/UI/Compose.php

Handle ';' to delimit addresses when composing.

MFH 1.373

If removing entries from the array, we need to reindex the array - if we end up
with a 1 element array, and that element is not index 0, we will get undefined
errors later on.

MFH: Add option to attach personal vCard to message.

MFH: 1.372

MFH: 1.371

Fix variable name.

Fix logic.

Bug: 6986
MFH:
1.1148    +1 -0      imp/docs/CHANGES
1.370     +6 -5      imp/lib/Compose.php

Bug: 6986
Fix address MIME encoding issues when saving a draft.

Add option to attach personal vCard to message.

MFH:
1.368     +3 -3      imp/lib/Compose.php
1.8       +4 -4      imp/lib/IMAP/MessageCache.php
1.696     +2 -2      imp/lib/IMP.php
1.80      +3 -3      imp/lib/Identity/imp.php
1.10      +2 -2      imp/lib/SpellChecker.php
1.16      +2 -2      imp/lib/UI/Message.php

Use alternatives to array_unique().

The old way of handling compose messages when the session timed out was
kludgy, never worked properly for me, isn't usable unless the user logs
back in, and doesn't work if using a custom login page
Rewrite using VFS to store the draft, which will be accessible on the next
login.

MFH 1.366

Correctly set charset on RFC822/message part name.

MFH 1.365

Remove broken code that relies on a (since-changed) private function in MIME::.

MFH: 1.364

Catch and log VFS errors.

MFH:
1.1127    +1 -0      imp/docs/CHANGES
1.362     +104 -21   imp/lib/Compose.php

Tags: IMP_4_2

MFH 1.363

fix typo

[cjh] Fix sending email to contact lists/RFC822 Groups (Bug #6732).

MFH: CHANGES - 1.1115, 1.1116; Compose.php - 1.360, 1.361

Tags: IMP_4_2_RC4

Bug: 6645
Add BINARYMIME capabilities.

Bug: 6645
If using SMTP, send messages using 8BITMIME if available

MFH: compose.php - 2.1090; Compose.php - 1.359; UI/Compose.php - 1.22

Clean up handling of IMP_Contents objects a bit. Don't grab headers objects
when we don't need them.

MFH: 1.358

Set the outermost MIME part's id to 0, otherwise it will be (incorrectly) set
to 1 when later added to the MIME_Message object through addPart().

MFH: Fix determination of reply list e-mail address in certain situations.

Fix determination of reply list e-mail address in certain situations.

MFH: 1.356

Run reply message through tidy if available. Finally allows me to reply to
Ben's broken Apple Mail message. :)

MFB:
[jan] Support vhosts setting when loading header.php, servers.php,
spelling.php and trailer.txt configuration files.

[jan] Support vhosts setting when loading header.php, servers.php,
spelling.php and trailer.txt configuration files.

MFH: Correctly handle parsing an address list when the personal portion may
have already been decoded.

Correctly handle parsing an address list when the personal portion may have
already been decoded.

MFH 1.353

Tags: IMP_4_2_RC3

Bug: 6330
Fix undefined index

MFH: 1.352

Apply message limit as early as possible, and fix some charset conversion issue.

MFH: 1.351

Filter HTML body when replying to HTML messages with the WYIWYG editor.

MFH: 1.350

Don't need to wrap the html part, the arguments were wrong anyway.
Pass charset to html2text filter.
Bug: 6268

Bug: 6268
MFH 1.349

Bug: 6268
Fix charset conversion in HTML part.

MFH 1.348

Use to value for 'reply_list' if no to value specified.

MFH: 1.347

Tags: IMP_4_2_RC2

Convert charset of mime part descriptions.
Bug: 6099

Bug: 6099
MFH 1.346

Bug: 6099
Make sure description in HTML part is sent in the charset the user selected,
not the browser charset.

MFH: 1.345

Use results of MIME_Magic::analyzeFile() if it succeeds.

Happy New Year

Happy New Year

Merge from HEAD.