Revisions for gollem/redirect.php

Happy New Year

Copyright assignments from Max.

Bump year, looks like a missed a few last time.

* Unify the creation of VFS objects into Gollem::getVFSOb()
* Make sure we assign a logger object to VFS
* Always check for PEAR_Error returns
Thanks slusarz for the advice

mirror changes from imp/redirect.php

[mms] Preserve URL anchor information when performing login.

Don't throw an error if there aren't any requested loginparams.

Happy New Year

Tags: GOLLEM_1_0_3

Happy New Year

Assign copyright to The Horde Project for those copyright holders that already agreed to it.

coding standards: don't use is_null().

The invisible commit: remove stray whitespace at end of line.

Bug: 3299
Submitted by: jpolansky@lsit.ucsb.edu
MFH: redirect.php - 1.61; Gollem.php - 1.194; CHANGES - 1.134

Tags: GOLLEM_1_0_2, GOLLEM_1_0_2_RC2

Bug: 3299
Submitted by: jpolansky@lsit.ucsub.edu
Allow direct autologin from login page if there are no additional login
parameters available.

Happy new year

Tags: GOLLEM_1_0_2_RC1

Happy new year\!

Bug: 3078
MFH: CHANGES - 1.126; redirect.php - 1.59

Tags: GOLLEM_1_0_1

Bug: 3078
Don't try to login using Horde auth credentials if hordeauth is off.

MFH: 1.58

ws

MFH: CHANGES - 1.118; login.php - 1.97; manager.php - 1.148;
redirect.php - 1.57; login.inc - 1.88

Tags: GOLLEM_1_0_1_RC1

[mms] Add language selection to login screen if using gollem as the
authentication driver.

Bug: 2491
Submitted by: martin@mein-horde.de
MFH: login.php - 1.95; redirect.php - 1.56

Bug: 2491
Submitted by: martin@mein-horde.de
logging message tweaks to be more similar to other Horde apps.

On bad login, return to the same backend screen that we tried to login to.

Tags: FRAMEWORK_3, GOLLEM_1_0, GOLLEM_1_0_RC2

Start to do a better job of exiting login procedure if autologin fails.

Tags: GOLLEM_1_0_RC1

Allow us to switch drivers via view.php.

[mms] Remove 'change_server' and 'change_port' configuration parameters and
instead allow admin to choose which VFS parameters can be overriden
by the user at login time via the backend configuration.

Tags: GOLLEM_1_0_BETA, GOLLEM_1_0_ALPHA1

Fix autologins when 'hordeauth' => 'full'.

Bug: 1607
A couple more $vfs -> $GLOBALS['gollem_vfs'] missed conversions.
Make sure directory is set correctly when logging in.

Consolidate loading of the backend configuration file into centralized code.
Change backend variable name to 'gollem_backends' to avoid confusion.

Use the backend label rather than the backend description.

Bug: 735
Allow user to switch between multiple backends during a single session.

Add the ability to store multiple backend states in the current session.  This
is the first step to allowing a user to be logged in to more than 1 backend
per Horde session at a time.

Happy New Year

Track Chuck's login/frameset changes with the gollem login code.

Allow the user to login via the selectlist window if they have not logged
into Gollem previously.

Bug: 785
Fix login rejection for backends that don't require credentials.

Insert code in the login screen to auto-detect the exact version of IE (version
5.0 +).  This allows us to only turn off page compression for the exact
versions of IE that are affected.  I am still not sure if I am embarassed at
how hackish this is or excited by how hackish this is :)

Bug: 785
Allow logins with empty credentials.

Login fixes for gollem.

Registry::getParam() -> Registry::get().

Convert Gollem authentication to use the Auth:: framework.

Fix URL generation.
Submitted by: Roel Gloudemans <roel@gloudemans.info>

Only support viewing one backend at a time now.  This is more consistent
with the rest of the Horde applications, and makes the code a whole heck
of a lot easier to read.
While cleaning out, clean up a lot of other stuff too (i.e. unused functions).
Lots of phpdoc/phpdoc stubs added.

Update copyright years.
As far as I can tell, $_SESSION['gollem']['username'] is never created so there is no way this code block in redirect.php is ever run.  Look instead inside
the current backend_key to determine the credentials.

[mms] Encrypt passwords in session.
[mms] Moved all session creation code to Gollem_Session::.

Store authentication error reason/messages in a global array ($__autherrors).
This is a bit messy but necessary since we a) use Auth:: both statically and
via objects all over the place so there is no guarantee that
storing something in an object/static variable will be able to be accessed
elsewhere, and b) since we use Horde::authenticationErrorRedirect() to redirect
on most authentication problems (like session timeouts), or our logout
redirects are disjointed in code a long way from the actual authentication
failures, it starts to get really messy if we were to start explicitly
explicitly passing around specific Auth object variables all over the place.
This change has the additional benefit of allowing us to call
Auth::addLogoutParameters() with just the URL argument and having that
function automatically generate the correct parameters necessary to output
the error message on the login page. That function will still allow a
specific reason to be passed in if the calling code knows exactly what kind
of error it wants to throw.

Standardize logout messages by collecting them in Auth:: and using
Auth::addLogoutParameters() to generated the standardized parameters for logout
screens.
Goal: This allows us to add a new logout reason ('message') that will be
handled uniformly across our different login screens.  This reason will allow
us to (finally) use Auth's ability to output a customized error message (e.g.
the server is not responding) to the user instead of being restricted to
'failed', 'session', etc. preset messages.

backends.php is needed by the menu now, so make sure it's included in
base.php so it's available in all scripts.

a few minor tweaks while I'm in here.

Use the new Util:: class.

- fix logins
- streamline a few bits of code

LOG_* constants -> PEAR_LOG_*

[cjh] Add ability to view different backends side-by-side
(j.huinink@wanadoo.nl).

Still some issues, UI is pretty unintuitive, but I think I've ironed
out all the serious errors.

- more login screen cleanups
- fix a few typos/cleanup

Make the server list more dynamic; automatically log users in when
they select a server that doesn't require any more credentials, and
reload the form when they change servers to make sure the fields are
accurate.

conf.xml and server list.

Submitted by: Michael Cochrane <mike@graftonhall.co.nz>

Cleanups, check the credentials that the backend requires, fix logging
issues, and check for PEAR_Error objects, not false.

Apply some of Michael's changes - this isn't complete.

Clean up some variables, use $_GOLLEM['session'], use
Horde::getPost(), and make sure we're always using 'username', not
'imapuser', 'user', or 'ftpuser'.

style

cleanup and fix a few errors.

Gollem is now completely based on the VFS backend system. Things should be
functional now, for FTP at least.

Submitted by: Michael Varghese <mike.varghese@ascellatech.com>

use Horde::compressOutput()

Last bits of $_SESSION cleanup.

Next shot of superglobals patch. After MFH is completed I'll commit Horde,
IMP and Nag.

Submitted by: Nuno Loureiro <nuno@eth.pt>

be consistent in using 'url' instead of 'redirect_url'

some references cleanup/optimization, and make this work with windows ftp
servers that return a dos-style file listing.

take framework changes into account

fix for updated Auth:: api

Another two-parter, updating to keep in sync with IMP:

- add realms support to gollem (to keep auth and prefs unique on multi
server setups).

- add support to be Horde auth controller.

Following IMP's example:

- remove HTTP_SESSION_VARS[] check in favor of Gollem::setupSession()
- use Gollem::authenticate() return value
- be consistant about Gollem::logoutUrl()
- use reason=failed instead of reason=logout when setupSession() or
  authenticate() fail

Making it work...

- update for the new prefs (still needs UI work)
- update for the new registry
- fix renaming multiple files (UI is not final)
- move help js to the menu
- fix problem reporting menu item
- add 'show_dotfiles' server setting
- many misc fixes

The configuration array is now simply $conf. Any settings that must be
accessible unchanged (not overridden) should be put into $conf['horde'].
Everything else is fair game for applications to override.

(trying desperately to keep up)

- Move authentication and session creating from manager to redirect
- Get login form to submit to redirect finally
- Fix a few copy/paste problems in index

have imp and gollem specify their own password key names, and convert a few
other calls.

- get rid of Gollem_util:: class in favor of Gollem::
- add Gollem::setLabel()
- format dates and number (getting ready to put this in conf)
- document constants
- many other additions and fixes

Here we go:

- Move login submission to redirect.php
- Add GOLEM_BASE (works the same as IMP_BASE)
- Add file downloading
- Add a couple directory icons
- Allow creating folders in empty directories
- Fix all directory navigation problems (I hope)
- Fix files with spaces
- Fix default server selection (copy/paste oops)
- A few dozen cleanups