Revisions for genie/lib/Genie.php

don't need references for PHP 5 code.

Add comments

Remove "My Wishlists" item.

Don't automatically create wishlist. A lot of users just visits the module just to look like without actually use it. So create user default wishlist only when needed (adding item or navigate to wishlist management)

Skip other steps if no items in list

Use countShares

Count lists only once per session

Add pref to limit the number of shares after wich the special shared wishlist management is needed. Still need to find out a solution to not retreive always all shares.

Remove other constants - sorting

First set of constant removal - for actionIDs

Remove purchased_map global

Add basic item type definition

I doubt we will see any other driver than sql. So merge it with main drievr class to not have a file just for the singleton/factory.
Don't store the items list in driver cache as is not used later, just return them and save some memory usage.

is_a is deprecated, use instanceof

PHP5 style methos/constants definitions

There's no reason for the print links to require javascript. Make them
all accessible, make them use popup(this.href). Users with javascript
off will just get a blank window using the printer friendly display
styles; they can hit print themselves.

Sort blank categories using the translation for "Unfiled".

"@access public" is redundant.
Wrapping.
Use proper types in phpdoc.
Specify "@access private" correctly in phpdoc.

Remove extra stuff from @var lines in phpdoc.

Clean up phpdoc.

track share selection changes

Remove "optional" from phpdoc.

Remove @version.

Two more switched key and value.

My Wishlists link for Genie.

New menu.
Submitted by: Roel Gloudemans <roel@gloudemans.info>

Here's the discussed change to listShares(). $owner is now a restriction on the shares returned instead of a boolean; $userid must still have permission to see them.

Apps no longer need to call Help::javascript() - and indeed they shouldn't,
since it no longer exists.

Start moving Genie to the new Pref_CategoryManager code.

Creating new categories should work again.

This should take care of storing categories as plaintext in the
backends. When you get this update, you'll start seeing numbers for
all category values. Run the convert_categories scripts and you'll see
the names again.

What will *not* quite work (probably) is adding/deleting categories.

Hope no one minds this going in stages; it's just a *lot* easier that
way.

No more HORDE_LIBS.

Use '' instead of false to avoid problems with using the return value as a
share id/array_key_exists argument.

Genie::getDefaultWishlists() and similar permissions/guest/default
wishlist fixes.

move Menu.php to a framework package.

Use Identity::singleton().

Show notifications only from the requested message stack.

Identity moved to framework.

Fix Share:: method names.

These are by no means private constants. Remove the weird leading _
(it was my idea in the first place, for the record. Dunno why).

- Move Category into the framework.
- At the same time, rename the API to DataTree.
- shorten some method names while we're at it.

[cjh] Guests can now purchase items; they go through a form that requests
their email address so that they can confirm cancelling a gift
if necessary.

Purchase time is now recorded for everyone, and when a user purchases their
own item, their email address gets filled in also.

- fix handling of categories as was done earlier for Kronolith (give
the user the actual list of categories for the wishlist they're adding
to).

- Show item descriptions in the wishlist overview (takes more space,
but much more end-user friendly).

- More UI tweaks; link Urls in item names and descriptions

- Don't show description tooltips since the description is right there.

[cjh] Add sorting by item category.
[cjh] Fix filtering by purchased/unpurchased status.

Also:
- A few newer/nicer graphics
- Start some UI tweaks to get it looking a bit sharper and consistent with
other apps.

Convert Genie to the new nag-inspired driver model, add history tracking, and
associated html cleanups.

Simplify driver instantiation even more.

No hardcoded params anymore.

LOG_* constants -> PEAR_LOG_*

restore print links in menus.

Cache listShares() calls.

Better returning/checking of errors in getCategories()/listShares()
calls.

Last menu.php files.

Fix variable scope.

Nuke the rest of the constants.php files. You'll have to update your
prefs.php files from prefs.php.dist for this one. Yay less file
inclusion.

- Add an "itemselected" color slightly lighter than the "selected" color
- Sort by price correctly in Genie
- Use new sort direction graphics in Genie
- Only show sort direction graphics on the current column
- Clicking the current sort column header reverses the sort, whether or
not you click the triangle
- The current sort column is now highlighted all the way down, not just
the header.

A bunch of these UI changes could be applied to multiple Horde apps;
I'd appreciate feedback on them and whether we should propogate them.

Always default to the Unfiled category; much better from a user's
point of view since they can always fix the category later; this
removes one potentially unnecessary task from the task/note/event/item
creation process.

[cjh] Add a Horde_Block for Genie.
[cjh] Basic adding/listing/viewing/editing/deleting of items works.

By doing just a bit more in Horde_Share::, we can avoid looping
through the same data again later.

Initial Genie commit.