Revisions for framework/Share/Share/sql_hierarchical.php

MFH:
1.58      +6 -3      framework/Share/Share/sql.php
1.48      +6 -3      framework/Share/Share/sql_hierarchical.php

array_walk can only modify the original value if the callback takes the value
as a reference. _db->quote() takes it by value so the change doesn't stick.
Bug: 6883

MFH: 1.47

Run group ids through quote().

MFH: Don't cast group_uid to integer (Bug #6883).

No integer casts here either.
Bug: 6883

MFH: 1.45
Bug: 7347

Tags: HORDE_3_3

Remove all child shares when removing a share. Otherwise, they get orphaned.

Bug: 7347

use the write db here
Bug:  7302
Submitted by: Duck

We might be setting as a top level share, need to protect against null $parent

MFB: 1.17.2.22

No gettext.

Tags: HORDE_3_3_RC1

MFH: 1.41

Avoid infinite recursion...check that we aren't attempting to set an existing
child share as the share's parent.

MFH: 1.40

avoid unnecessary assignment

MFH: 1.39

Add a countChildren() method to hierarchical driver.

MFH: 1.37 1.38

Make sure the permissions data is properly structured before creating the
share object

this method takes the full array, not the share_flags value

MFH: 1.36

When resetting the parent of a share, make sure we also reset the
parent of any children of that share.
Bug: 7171

MFH: 1.35

Make sure we always have a share_parent attribute set

MFH:
1.47      +8 -7      framework/Share/Share/sql.php
1.34      +8 -10     framework/Share/Share/sql_hierarchical.php
1.1132    +1 -0      horde/docs/CHANGES

SQL portability and quoting
Bug: 7084

MFH:

1.44      +69 -48    framework/Share/Share/sql.php
1.33      +10 -2     framework/Share/Share/sql_hierarchical.php
1.45      +10 -1     framework/Share/Share/sql.php

Free results and prepared statements where we can.

MFH:

1.40      +46 -19    framework/Share/Share/sql.php
1.30      +3 -3      framework/Share/Share/sql_hierarchical.php
1.31      +7 -1      framework/Share/Share/sql_hierarchical.php
1.41      +4 -8      framework/Share/Share/sql.php
1.32      +7 -7      framework/Share/Share/sql_hierarchical.php
1.42      +2 -1      framework/Share/Share/sql.php

Put these in _getShareCriteria()

Convert driver keys and charset in this driver as well.

clean up the _toDriver conversions.

MFH:
1.35      +3 -3      framework/Share/Share/sql.php
1.29      +2 -2      framework/Share/Share/sql_hierarchical.php

Need to use DISTINCT when both listing and counting shares, otherwise if
a share has more than one entry in a *_shares_users or *_shares_groups table
(as would be the case if you give explicit perms to more than one user/group)
the share will be returned / counted more than once in the results.

Log this query

MFH: 1.27 - better late then never...

Tags: HORDE_3_2_2, HORDE_3_2_1

give the hierarchical driver it's own _addShare() method, that doesn't
propagate the share_name

MFH: 1.26

Allow complex comparisons in _getShareCriteria

Bug: 6842
Submitted by: Duck

MFH: 1.25

Override getPermission() here since we don't use share names in hierarchical
shares. Also add a _getName() implementation to return an empty string to
avoid any future issues with other libraries expecting a share name.

MFH: 1.24

hierarchical shares don't have share_names

MFH:
1.30      +33 -1     framework/Share/Share/sql.php
1.23      +13 -4     framework/Share/Share/sql_hierarchical.php

More error checking and be sure to log any SQL errors

MFH:
1.27      +6 -6      framework/Share/Share/sql.php
1.22      +6 -6      framework/Share/Share/sql_hierarchical.php

Tags: HORDE_3_2

More portable SQL bitwise comparisons.

Bug: 6751

MFH: 1.21

this function takes the whole array, not the share_flags value

MFH: 1.20

Fix loading permissions for user/groups

MFH: 1.19

allow clearing a share's parent - making it a top-level share.

MFH: 1.18

Tags: HORDE_3_2_RC4

Need to implement these methods in this class instead of the base class
since we are not using share_names at all in the hierarchical driver.
Not doing this leads to infinite loops as the shareMap and cache is
keyed by share_name, which is always empty.

Merge the hierarchical sql share driver to FW_3

This was the only thing forcing applications to continue to use a share_name
when they are really not needed. Hierarchical shares are not likely to need
share_names, and if a specific application wants them, it can be overridden.

Tags: FRAMEWORK_3

heh, guess I should have looked in sql.php first :)
Fix this in the same style as the way it's done in sql.php.

The entire attribute query needs to be in it's own grouping

Don't sort by share_name, use attribute_name when 'name' is chosen...just
like in the sql driver.

- Fix limiting shares by a particular user
- Use DISTINCT in countShares() (at least for now) to deal with the case where
a share owner might also be listed in the *_share_users table for the share.

Need to group these conditions together

some more DB -> MDB2 leftovers

this isn't used anymore now that it's MDB2

Horde_Share_sql (which this extends) uses MDB2 now

- Rename "perm_extra" to "share_flags" because that's how it's being used
- adjust flags to be a real bitmask with constants
- Set perm_creator, perm_default, and perm_guest to 0 (no perms) by default
- Adjust code accordingly

- Need to check if $parent is an object before we try to use it to build a
cache key.

- Allow for share_parents to be '' or NULL to be more portable.

This can now actually use the parent class' _save() method

Still needs work, but at least now the hierarchical stuff is actually
working :)

Need to override the base class' countShares() method, not _countShares()
Update some phpdoc to reflect actual return values
Add getParents() method to return all Horde_Share_Object parent objects.

convert charset where needed

Use $this->_tableColumns here also.
Add stub for inheritPermissions() method

Initial hierarchical sql share driver implementation ported from Duck's
Ansel sql share code. This one extends the sql share driver. Not ready for
use, still some things that need to be fixed (some REPLACE INTO stuff for starters).

Will merge into FW_3 once it's tested :)