Revisions for framework/Share/Share/sql.php

MFH: 1.60, 1.61

actually, we should probably use the singleton method instead of factory here

Need a reference here

MFH:
1.59      +23 -31    framework/Share/Share/sql.php
1.1177    +2 -0      horde/docs/CHANGES

[cjh] Don't use executeMultiple in the SQL Share driver when we might
reset the connection in between queries (Bug #7542).

MFH:
1.58      +6 -3      framework/Share/Share/sql.php
1.48      +6 -3      framework/Share/Share/sql_hierarchical.php

array_walk can only modify the original value if the callback takes the value
as a reference. _db->quote() takes it by value so the change doesn't stick.
Bug: 6883

MFH: 1.57

Run group ids through quote().

MFH: Don't cast group_uid to integer (Bug #6883).

More casts removed. It would really help if people that report issues that we
can't reproduce would actually test our fixes!
Bug: 6883

Don't cast group ids to integers.
Bug: 6883

copy/paste error

Log at least these queries...

MFH: 1.52

Tags: HORDE_3_3

Unset charset for the read database too. This has to be done in all places
where we use MDB2.

MFH: MDB2 sequence changes

1.51      +3 -1      framework/Share/Share/sql.php
1.1       +84 -0     ingo/scripts/upgrades/2008-08-29_fix_mdb2_sequences.php (new)
1.1       +84 -0     kronolith/scripts/upgrades/2008-08-29_fix_mdb2_sequences.php (new)
1.1       +84 -0     mnemo/scripts/upgrades/2008-08-29_fix_mdb2_sequences.php (new)
1.1       +84 -0     nag/scripts/upgrades/2008-08-29_fix_mdb2_sequences.php (new)
1.1       +84 -0     turba/scripts/upgrades/2008-08-29_fix_mdb2_sequences.php (new)
1.1153    +1 -0      horde/docs/CHANGES
1.201     +2 -1      ingo/docs/CHANGES
1.467     +1 -0      kronolith/docs/CHANGES
1.142     +1 -0      mnemo/docs/CHANGES
1.235     +1 -0      nag/docs/CHANGES
1.450     +1 -0      turba/docs/CHANGES
1.8       +6 -2      ingo/docs/UPGRADING
1.11      +6 -2      kronolith/docs/UPGRADING
1.10      +6 -2      mnemo/docs/UPGRADING
1.9       +6 -2      nag/docs/UPGRADING
1.37      +6 -2      turba/docs/UPGRADING
1.9       +7 -2      ingo/docs/UPGRADING
1.12      +7 -2      kronolith/docs/UPGRADING
1.11      +7 -2      mnemo/docs/UPGRADING
1.10      +7 -2      nag/docs/UPGRADING
1.38      +7 -2      turba/docs/UPGRADING
1.2       +1 -49     ingo/scripts/upgrades/2008-08-29_fix_mdb2_sequences.php
1.2       +1 -49     kronolith/scripts/upgrades/2008-08-29_fix_mdb2_sequences.php
1.2       +1 -49     mnemo/scripts/upgrades/2008-08-29_fix_mdb2_sequences.php
1.2       +1 -49     nag/scripts/upgrades/2008-08-29_fix_mdb2_sequences.php
1.2       +1 -49     turba/scripts/upgrades/2008-08-29_fix_mdb2_sequences.php

Tags: HORDE_3_3_RC1

Have MDB2 use 'id' for sequence names -
Be sure to run the fix_mdb2_sequences upgrade script in the applications
that use sql shares.

MFH: 1.50

data[share_id] won't exist if the share has not been saved, return NULL and
avoid array key not found warnings.

MFH 1.49

- hack to fix s.* field names for sqlite. MDB2 is supposed to fix this for us, but doesn't.
- set consistent options on the read and write dbs.

MFH

Always select the database before a query with MDB2. This matches DB's
behavior and is necessary in case the current database has changed from the
outside.
Bug: 6997

MFH:
1.47      +8 -7      framework/Share/Share/sql.php
1.34      +8 -10     framework/Share/Share/sql_hierarchical.php
1.1132    +1 -0      horde/docs/CHANGES

SQL portability and quoting
Bug: 7084

ws

MFH:

1.44      +69 -48    framework/Share/Share/sql.php
1.33      +10 -2     framework/Share/Share/sql_hierarchical.php
1.45      +10 -1     framework/Share/Share/sql.php

No need to limit the results we free to those we get back from prepared
statements...free all result objects once we are done with them.

Commit a modified version of Selsky's patch for freeing prepared queries
and results.  I removed the $result->free() calls from the $result that
is returned from manipulation queries, as they don't return a MDB2_Result
object...

MFH: 1.43

Log and return proper object.

MFH:

1.40      +46 -19    framework/Share/Share/sql.php
1.30      +3 -3      framework/Share/Share/sql_hierarchical.php
1.31      +7 -1      framework/Share/Share/sql_hierarchical.php
1.41      +4 -8      framework/Share/Share/sql.php
1.32      +7 -7      framework/Share/Share/sql_hierarchical.php
1.42      +2 -1      framework/Share/Share/sql.php

oops.

Put these in _getShareCriteria()

clean up the _toDriver conversions.

MFH: 1.39

Need to translate attribute keys

MFH: 1.38

Catch errors from any prepare() call.

MFH: 1.37

well, that was silly...we were looping through the tables we needed, we
just weren't using the right variable in the SQL statement.

MFH: 1.36

Remove all user and group entrires for the deleted share.
Related to Bug: 6968

MFH:
1.35      +3 -3      framework/Share/Share/sql.php
1.29      +2 -2      framework/Share/Share/sql_hierarchical.php

Need to use DISTINCT when both listing and counting shares, otherwise if
a share has more than one entry in a *_shares_users or *_shares_groups table
(as would be the case if you give explicit perms to more than one user/group)
the share will be returned / counted more than once in the results.

MFH 1.34

Tags: HORDE_3_2_2, HORDE_3_2_1

only log errors
Bug: 6873

MFH:
1.33      +2 -2      framework/Share/Share/sql.php
1.1103    +2 -0      horde/docs/CHANGES

[cjh] Fix deletion of SQL shares when using split read/write databases
(duck@obala.net, Bug #6870).

MFH: 1.32

Remove more dead code.

MFH: 1.31

$data['perm'] is not set here, so don't try to unset it.

MFH:
1.30      +33 -1     framework/Share/Share/sql.php
1.23      +13 -4     framework/Share/Share/sql_hierarchical.php

More error checking and be sure to log any SQL errors

MFH: 1.29

more error checking

MFH: 1.27

Catch error

Bug: 6804

MFH:
1.27      +6 -6      framework/Share/Share/sql.php
1.22      +6 -6      framework/Share/Share/sql_hierarchical.php

Tags: HORDE_3_2

More portable SQL bitwise comparisons.

Bug: 6751

Looks like a merge went bad at some point...

ws

MFH: 1.25

Tags: HORDE_3_2_RC4

fix numerous issues with share perms. Mostly fixes cases where a share has
a specific user and/or group permission set as well as a guest perm set. This
was causing everything but user/group permissions from being shown.

Also some issues where user and group perms were not being populated
correctly.

Testing welcome :)

MFH: 1.24

One more DB -> MDB2 conversion along with a few formatting nits

Submitted by: Duck

MFH 1.23

When sorting by name, we almost certainly want attribute_name, not
share_name (and we can get share_name by leaving the sort field as
null).

- Fix limiting shares by a particular user
- Use DISTINCT in countShares() (at least for now) to deal with the case where
a share owner might also be listed in the *_share_users table for the share.

MFH: 1.21

Fix ->setLimit() call....it's not an assignment!

MFH: 1.20

Fix variable name

MFH: 1.19
SQL Shares now require MDB2

Change the sql share driver to use MDB2 instead of the old DB.

MFH:
1.18      +37 -29    framework/Share/Share/sql.php
1.6       +5 -5      ingo/scripts/sql/ingo.oci8.sql
1.9       +5 -5      ingo/scripts/sql/ingo.sql
1.7       +10 -2     ingo/scripts/upgrades/1.1_to_1.2.php
1.9       +5 -5      kronolith/scripts/sql/kronolith.mssql.sql
1.13      +5 -5      kronolith/scripts/sql/kronolith.mysql.sql
1.13      +5 -5      kronolith/scripts/sql/kronolith.oci8.sql
1.11      +5 -5      kronolith/scripts/sql/kronolith.pgsql.sql
1.11      +5 -5      kronolith/scripts/sql/kronolith.sql
1.6       +7 -7      kronolith/scripts/sql/kronolith.xml
1.5       +5 -5      kronolith/scripts/upgrades/2.1_to_2.2.pgsql.sql
1.8       +11 -2     kronolith/scripts/upgrades/2.1_to_2.2.php
1.5       +5 -5      kronolith/scripts/upgrades/2.1_to_2.2.sql
1.5       +5 -5      mnemo/scripts/sql/mnemo.mssql.sql
1.4       +5 -5      mnemo/scripts/sql/mnemo.oci8.sql
1.9       +5 -5      mnemo/scripts/sql/mnemo.sql
1.3       +7 -7      mnemo/scripts/sql/mnemo.xml
1.7       +10 -2     mnemo/scripts/upgrades/2.1_to_2.2.php
1.2       +5 -5      mnemo/scripts/upgrades/2.1_to_2.2.sql
1.11      +5 -5      nag/scripts/sql/nag.mssql.sql
1.11      +5 -5      nag/scripts/sql/nag.oci8.sql
1.15      +5 -5      nag/scripts/sql/nag.sql
1.7       +7 -7      nag/scripts/sql/nag.xml
1.7       +10 -2     nag/scripts/upgrades/2.1_to_2.2.php
1.3       +5 -5      nag/scripts/upgrades/2.1_to_2.2.sql
1.4       +5 -5      turba/scripts/sql/turba.mssql.sql
1.4       +5 -5      turba/scripts/sql/turba.oci8.sql
1.5       +5 -5      turba/scripts/sql/turba.pgsql.sql
1.4       +5 -5      turba/scripts/sql/turba.sql
1.4       +8 -8      turba/scripts/sql/turba.xml
1.2       +5 -5      turba/scripts/upgrades/2.1_to_2.2_add_sql_share_tables.mssql.sql
1.2       +5 -5      turba/scripts/upgrades/2.1_to_2.2_add_sql_share_tables.oci8.sql
1.2       +5 -5      turba/scripts/upgrades/2.1_to_2.2_add_sql_share_tables.pgsql.sql
1.2       +5 -5      turba/scripts/upgrades/2.1_to_2.2_add_sql_share_tables.sql
1.11      +10 -2     turba/scripts/upgrades/2.1_to_2.2_datatree_to_sql_share_migration.php

- Rename "perm_extra" to "share_flags" because that's how it's being used
- adjust flags to be a real bitmask with constants
- Set perm_creator, perm_default, and perm_guest to 0 (no perms) by default
- Adjust code accordingly

MFH: 1.17

Don't overwrite the perms array if it already exists

MFH: 1.16

We are joing the groups table with the shares table, not with itself.

MFH: 1.15

Convert charset if needed on the attributes we're filtering on.

MFH: 1.14

Make sure we convert from/to the SQL server's charset when needed.
Still need to check the conversion on any attributes we pass in to search
by.

MFH 1.13

Get the list of columns for the specific share table; sqlite at least
returns columns as 's.share_id' instead of 'share_id' if we do SELECT
s.*, so this works around that.

MFH: 1.12

remove dead code

MFH`

Allow paging of results from a listShares() call

MFH: 1.20 1.10

Add ability to have Horde_Share_Object be instantiated as an arbitrary
sub-class

MFH: 1.9

Need to set the share object here

MFH 1.8

Always need these checks.

MFH 1.7

Remove commented-out and unused code (I can see the point, but we
should just provide a straight list() with no objects function instead
of having alternate objects, imo).

MFH 1.6