Revisions for framework/Share/Share.php

MFH: 1.164

There is no need to set owner permissions explicitly when creating a new
share, share owners are assumed to always have full permissions.

This fixes an issue with the sql share drivers that was causing permissions
checks to fail.

MFH`

Tags: HORDE_3_2_1, HORDE_3_2, HORDE_3_2_RC4

Allow paging of results from a listShares() call

MFH 1.162

Tags: HORDE_3_2_RC3

Add a missing error check

Happy New Year

Tags: HORDE_3_2_RC2

Happy New Year

Merge from HEAD.

Add @since tags.

Tags: BEFORE_MERGE_3_2

Add countShares()
Submitted by: duck@obala.net

Remove debug code. Looks like share caching is working again. :)

Tags: HORDE_3_2_RC1

Round 2 of Share refactoring. Probably broke a few things and the Kolab driver is completely untested.

Round 1 of Share cleanup: nuke extra storage class.

Copyright assignments, email updates.

First round of copyright assignments.

Collapse this function into the parent class since the child classes don't differ.

Call this hook from Horde_Share_Object_datatree instead of DatatreeObject_Share so we can pass the whole Horde_Share_Object to the hook, as we did before...
(thanks for the input, chuck).

Tags: HORDE_3_2_ALPHA

Bump year, looks like a missed a few last time.

More reference fixes.
Bug: 5355
Submitted by: thomas (dot) jarosch (at) intra2net (dot) com

PHP 4 reference fix (thomas (dot) jarosch (at) intra2net (dot) com, Bug #5355).

Nit

Propogate return value from Horde_Share_Object set() function.
Bug: 5082
Submitted by: wrobel@pardus.de

$groups can be false.

Tags: HORDE_3_1_8, HORDE_3_1_7, HORDE_3_1_6, HORDE_3_1_5, HORDE_3_1_4, HORDE_3_1_4_RC1

Happy New Year

Happy New Year

Fix share caching. I'm pretty sure it's rendered useless now, since we need to
load the object from datatree even if we have it in the cache already, but at
least it works at all.

Assign copyright to The Horde Project for those copyright holders that already agreed to it.

[cjh] Horde_Share now has a driver system with DataTree and Kolab backends
(Gunnar Wrobel <wrobel@pardus.de>, Request #4263).

Also greatly simplify the Horde_Share API while we're at it.

MFB: 1.111.2.21

Stricter test.

Fix a reference.

Reset caches that can't be updated when removing or adding shares.

Add share caching.

MFH 1.137, 1.138

Tags: HORDE_3_1_3, HORDE_3_1_2

Return success value.

Group has to be specified as the group id here.

MFH: 1.136

MFH: 1.135

Add removeGroup().

Helps to save the permission after removing the user.

MFH: 1.134

Fix group permission checks.
Bug:  3646

Happy new year

Tags: HORDE_3_1_1, HORDE_3_1, HORDE_3_1_RC3, HORDE_3_1_RC2, HORDE_3_1_RC1

Happy new year\!

Merged from HEAD.

MFH: 1.132

Tags: HORDE_3_0_12, HORDE_3_0_11, HORDE_3_0_10, HORDE_3_0_9, HORDE_3_0_8, HORDE_3_0_7, HORDE_3_0_6, HORDE_3_0_6_RC1

References.

Tags: BEFORE_MERGE_3_1

Wrapping

phpdoc

Check for PEAR_Errors.

MFH: Remove "@access public" and fix formatting/wrapping.

Tags: HORDE_3_0_5, HORDE_3_0_5_RC2, HORDE_3_0_5_RC1

Remove "@access public" and fix formatting/wrapping.

MFH: 1.127

Fix spelling in phpdoc.

MFH: Clean up phpdoc.

Clean up phpdoc.

No sense in returning integers by reference.

MFH: "optional" not needed in phpdoc.

"optional" not needed in phpdoc.

MFH 1.123

phpdoc

MFH 1.122

Fix phpdoc

Retrieve galleries and sort them in one datatree hit.

Bug: duck@obala.net

MFH 1.120

Tags: HORDE_3_0_4, HORDE_3_0_4_RC2

Fix countShares() caching key.
Submitted by: Ben Chavet <ben@horde.org>

[cjh] Allow for arbitrary attribute filters when listing or counting Share
objects (Duck <duck@obala.net>).

MFH 1.118

Tags: HORDE_3_0_4_RC1

Fix case

MFH 1.117

phpdoc improvements

MFH 1.115, 1.116

Tags: HORDE_3_0_3, HORDE_3_0_3_RC1

kill @version

Missing a few variables in the cache key here.

MFH 1.114

After all it's a debug message. So keep it being logged but use a more neutral message.

MFH 1.113

Avoid creating meaningless error messages in the logs.

Happy New Year

Happy New Year

Tags: HORDE_3_0_2, HORDE_3_0_1

Instead of hardcoding '-1' in tons of places, use a new constant: DATATREE_ROOT. Much more readable, etc. At the same time, make this an int (-1) instead of the string value ('-1') which was inconsistent with all other datatree ids, buggy, etc.

Tags: FRAMEWORK_3, HORDE_3_0

Fix logic (Duck <duck@obala.net>).

Tags: HORDE_3_0_RC3

- owner criteria needs to be JOINed (it's a seperate set of tests) and
we want to restrict the set of tests to the same datatree_id (need to
pass all AND tests for the same datatree_id, but not for the same
attribute_name.

Here's the discussed change to listShares(). $owner is now a restriction on the shares returned instead of a boolean; $userid must still have permission to see them.

This doesn't make sense, it'd check for empty owners.

Fix some of the $owner logic (Ben Chavet <ben@chavet.net>).

Second attempt at the share hooks:
- removed the config options; the hooks are now always called if defined, through Horde::callHook()
- added a new parameter to Horde::callHook() that is used as the return value on failure; by default a PEAR_Error object is returned as was the case previously

First shot at implementing hooks for share init, add, modify, remove and list events

Fix sorting if parent shares are missing in the share list, for example due to permission restrictions.

We need to call setDataTree() on new objects.

Use DataTreeObject::save().

Make the datatree limit functionality available to shares and in ansel.

Submitted by: Duck <duck@obala.net>

!isset() -> empty()

Fix copy 'n' paste error.

Fix parameters.

Add countShares() (from duck@obala.net) and move criteria tree
generation into a seperate function.

doc formatting

Remove share type (private/public). This can he perfectly handled by perms as
well. More modules coming.

phpdoc

Add getDataTree(), phpdoc fixes.

Set share owner to current user by default.
Fix "keep-at-least-one-share" code.