Revisions for framework/Prefs/Prefs.php

MFH 1.194

check for errors from hook functions
Bug: 7404
Submitted by: duck@obala.net

MFH:
1.193     +4 -1      framework/Prefs/Prefs.php
1.1101    +2 -0      horde/docs/CHANGES

Tags: HORDE_3_3, HORDE_3_3_RC1, HORDE_3_2_2, HORDE_3_2_1

[cjh] Fix storing of unlocked preferences set by hooks
(manuel@mausz.at, Bug #6822).

MFH:
1.192     +29 -15    framework/Prefs/Prefs.php
1.1096    +2 -0      horde/docs/CHANGES

[cjh] Fix over-zealous preference caching when preferences are requested for a
different user (Bug #6820).

MFH:
1.191     +32 -5     framework/Prefs/Prefs.php
1.1050    +2 -0      horde/docs/CHANGES

Tags: HORDE_3_2, HORDE_3_2_RC4, HORDE_3_2_RC3

[cjh] Make sure that when we used a cached Preferences object, we set the
correct scope (Bug #6395).

Happy New Year

Tags: HORDE_3_2_RC2

Happy New Year

Merge from HEAD.

Jon has assigned his copyrights to The Horde Project.

Tags: BEFORE_MERGE_3_2, HORDE_3_2_RC1, HORDE_3_2_ALPHA

Bump year, looks like a missed a few last time.

MFB: 1.137.10.30

Add $caching parameter to the singleton signature. If we load a cached
preference instance before a non-cached, the non-cached will be cached
instead.
This fixes notifications for downloaded linked attachments being sent to the
logged-in user instead of the message sender.

Tags: HORDE_3_1_9, HORDE_3_1_8, HORDE_3_1_7, HORDE_3_1_6, HORDE_3_1_5

This function should always return a boolean. Splitting hairs a little, but var_dumping and expecting to get a boolean here and getting '4' leads to less confidence in your debugging.

Happy New Year

Tags: HORDE_3_1_4, HORDE_3_1_4_RC1

Fix two shared preference bugs, both of which could cause Bug #4378:
- load the defaults for shared preferences into the horde scope, not the scope
of the app that marks them shared
- retrieve shared prefs when loading the horde scope even though we might not
have a conf for them then, and don't overwrite the retrieved value when we
_do_ load the conf later.

MFH 1.184

Fix charset conversion of default preference values.
Bug: 4703

Fix hooks.

[cjh] Add preferences change hooks that are called when preferences are set
to new values (Request #4343).

[cjh] Rewrite the Prefs code to keep the same Prefs object through multiple
scope changes, instead of re-loading the Horde prefs, or prefs for
a scope that had already been loaded. Fixes bugs when making changes
to preferences and then switching scopes again (Bug #2838).

This is a big change to the prefs system, and while I've tested all of
it as best as I can, and the SQL driver I'm pretty confident in, this
needs testing before we even think about merging it. It would all be
BC, though.

Please let me know (or update the bug) if this works or doesn't work
for you, especially people using lots of hooks and other more edge
cases, and also let me know if you think it should be merged or not.

$result is an empty array if the application doesn't have a prefs.php.

Vhost'ed preference configuration.
Use Horde::callHook().

MFH 1.178

Tags: HORDE_3_1_3, HORDE_3_1_2

Don't include hooks file more than once.
Submitted by: duck@obala.net

Only update cache if preference actually changed (i.e. dirty bit is set).

Revert 1.174

MFB

This change broke the preference cache completely.

MFH: 1.174

Don't fail with old configurations.

MFH: 1.173

This reference was important.

MFH: Drop 'none' prefs driver and make 'session' the default.

Drop 'none' prefs driver and make 'session' the default.

no need to silence

Shutdown function doesn't work without this. Of course.
Bug: 3776

Fix hooks on locked preferences.

MFH 1.168

Don't silence includes.

Remove some unnecessary references and minor cleanup.

MFH: Horde_String not used in all prefs backends.

Horde_String is not required by all prefs backends.

phpdoc cleanups
cache cleanups.  cacheUpdate() is now only called with the preferences that
need to be updated, instead of always updating the entire prefs array. On
my server, this reduced the number of assignments in cacheUpdate() from 2173
to 379. i think there is still some more tweaking that can be done in here.

MFH 1.164

Tags: HORDE_3_1_1, HORDE_3_1

simplify

Bug: 3372
MFH: Prefs.php - 1.161-1.163; imsp.php - 1.12; ldap.php - 1.105;
sql.php - 1.114

Move all cache updating to cacheUpdate().
Make sure to remove entries from cache when remove() is called.

Don't think we need the '_filled' entries since we can simply check for the
presence of the 'scopename' in the prefs_cache array.

Bug: 3372
Update prefs_cache on setting the preference value.

Warn user if loading prefs fails.

Happy new year

Tags: HORDE_3_1_RC3, HORDE_3_1_RC2, HORDE_3_1_RC1

Happy new year\!

- Don't call Horde::fatal() in prefs drivers
- Remove call to Horde::serviceDegraded()
- Go back to only connecting to the backend if we actually need to - most
page loads should never hit the prefs backend due to the session cache.

MFH

Revert 1.155. It is not the factory's job to create singletons. That's what singleton() is for. Fixes partially bug 3050.

MFH 1.156

we can merge these preferences much more conveniently.

MFH 1.155

Don't create a whole new Prefs:: object when we are just changing the scope.

ah, forgot to commit the parent classes for the failover logic

MFH: Fixes for reference warnings with PHP 5.1.

Fixes for reference warnings with PHP 5.1. If someone could merge
these it'd be appreciated, I'm not up to it right now and will be
swamped come morning.

MFH: Remove obsolete @since tags.

Remove obsolete @since tags.

Merged from HEAD.

MFH 1.151

Tags: HORDE_3_0_12, HORDE_3_0_11, HORDE_3_0_10, HORDE_3_0_9, HORDE_3_0_8, HORDE_3_0_7, HORDE_3_0_6, HORDE_3_0_6_RC1, HORDE_3_0_5

After further review, this Auth check is not needed either.

Tags: BEFORE_MERGE_3_1

MFH: CHANGES - 1.712; Prefs.php - 1.150

Fix botched revert from 3 years ago.  My bad.

MFH: Remove "@access public" and fix wrapping.

Tags: HORDE_3_0_5_RC2, HORDE_3_0_5_RC1

Remove "@access public" and fix wrapping.

MFH: 1.148

Always call prefs hooks on default values.

MFH: Remove object keywords from phpdoc.

Remove object keywords from phpdoc.

Add PHP5 __get and __set functions to PHP5 code can just do $prefs->pref_name.

MFH: Clean up types in phpdoc.

Clean up types in phpdoc.

MFH: Clean up phpdoc for constants.

Clean up phpdoc for constants.

MFH 1.143

Cache some NLS::getCharset() calls in often called methods.

MFH: "optional" not needed in phpdoc.

"optional" not needed in phpdoc.

revert

Add username to the cache key. This was causing problems with freebusyURL's

Remove @version.

Remove @version.

Happy New Year

Happy New Year

Tags: HORDE_3_0_4, HORDE_3_0_4_RC2, HORDE_3_0_4_RC1, HORDE_3_0_3, HORDE_3_0_3_RC1, HORDE_3_0_2, HORDE_3_0_1

Registry::getParam() -> Registry::get().

Tags: FRAMEWORK_3, HORDE_3_0, HORDE_3_0_RC3

Trim ws.

Don't convert charset of prefs when storing them into the backend but keep
them already converted in the prefs cache.
This is necessary for example for serialized data like identities. When we
retrieved such prefs with another charset than we used to store them, the
conversion happened on the serialized string, breaking the unserialization
because the string lengths were not correct anymore.
Code that needs to store serialized data can now do the conversion itself,
serialize the data and then store it while telling the prefs backend to *not*
convert it automatically.

phpdoc fixes
Submitted by: Andrew Coleman <mercury@appisolutions.net>

Add clear() method. Someone has to implement that for the LDAP driver.

No more HORDE_LIBS.

[cjh] Prefs::getPref() has been deprecated and is no longer present.

Tags: HORDE_3_0_ALPHA

Add "password" preference type.
Submitted by: Michael Rubinsky <mike@theupstairsroom.com>

Use isset() instead of !is_null() to avoid undefined index warnings.