Revisions for dimp/compose.php

MFH 1.118

Tags: DIMP_1_1, DIMP_1_1_RC2

What we need is the browser's charset here, not the charset desired to send
the message with.  This fixes encoding the headers for drafts if not using
UTF-8.

MFH:
1.117     +11 -3     dimp/compose.php
1.119     +2 -0      dimp/docs/CHANGES
1.119     +1 -1      dimp/js/compose.js
1.114     +2 -4      dimp/js/src/compose.js
1.33      +1 -2      dimp/lib/Views/Compose.php

Correctly close popup compose windows when opened from a page other than
the base DIMP page.

Bug: 7059
MFH:
1.116     +2 -1      dimp/compose.php
1.118     +1 -1      dimp/js/compose.js
1.42      +1 -1      dimp/js/fullmessage.js
1.113     +6 -2      dimp/js/src/compose.js
1.39      +5 -4      dimp/js/src/fullmessage.js
1.32      +4 -2      dimp/lib/Views/Compose.php
1.70      +2 -1      dimp/message.php

Tags: DIMP_1_0_1_RC1

Bug: 7059
Attempt to work around some IE & Xinha issues.

MFH:
1.20      +1 -1      dimp/js/DimpSlider.js
1.20      +3 -5      dimp/js/src/DimpSlider.js
1.115     +2 -2      dimp/compose.php

Fix logic.

MFH:
1.114     +3 -3      dimp/compose.php
1.225     +2 -2      dimp/imp.php
1.117     +1 -1      dimp/js/compose.js
1.112     +26 -29    dimp/js/src/compose.js
1.145     +13 -9     dimp/lib/DIMP.php
1.31      +1 -2      dimp/lib/Views/Compose.php
1.39      +2 -2      dimp/lib/base.php

Tweak closing compose screen and display of notification messages if there is
no base window.

Fix comment

MFH:
1.107     +6 -1      dimp/js/src/compose.js
1.112     +5 -2      dimp/compose.php
1.109     +1 -0      dimp/docs/CHANGES

Update mailbox if drafts message has been deleted.

MFH:
1.111     +2 -1      dimp/compose.php
1.69      +2 -1      dimp/index.php
1.139     +10 -3     dimp/lib/DIMP.php
1.69      +2 -1      dimp/message.php

Move javascript loading to the bottom of the HTML output.  Especially useful
on login - loads to the 'Loading...' screen immediately to give users a better
responsiveness feel.

MFH: Move variables to DIMP namespace. Fix scope issue in compose.js.

Tags: DIMP_1_0

Due to inconsistencies in browsers, it is necessary to store dynamic JS
variables in a global DIMP variable rather than in individual classes (or else
the class may not exist when we are trying to populate with data, etc.).
Fix a scope issue in compose.js.

MFH: compose.php - 1.109; Compose.php - 1.29; message.php - 1.64;
chunks/compose.php - 1.142

Tags: DIMP_1_0_RC4

Move some stuff out of the compose library and move it to where it makes
more sense.

MFH: Split message template into separate preview and fullmessage templates.

Want to get this in before 1.0 because it changes template files so much...
Rework message display code. Preview mode vs. popup message mode are really
two different things. Hard code the message template into both views.  The
major benefit is we no longer have to create the full HTML page/set
event observers every time we view a preview message - we can set it up once
on login and simply update the relevant fields with the new information.
Greatly reduces bandwith and lessens resource needs on server side.  The
only drawback is the change of several templates and the addition of a new
hook for preview messages - since we are dynamically populating at load time,
we can't adopt the old template approach.  But there is a net -1 gain on
template files so that's always a good thing.

MFH: Merge the new event observer handling code.

Move javascript event handlers on compose screen to static JS files.

MFH: match IMP's new names for forwarding types.

Move all event observers for both the main page and the message screens (except
for 2 calls) to javascript code so 1) it can be cached/compressed, 2) we
finally use the correct cross-browser Event library rather than doing straight
HTML-level 'onclick' handlers.

MFH: Set the timezone where necessary.

Set the timezone where necessary.

MFB: Catch errors from parsing identity from lines.

Catch errors from parsing identity from lines.

MFH 1.103

rearrange code

MFH:
Add option to IMP::addInlineScript() to indicate whether code should be
loaded onload or on DOM load.
More correct JS numeric sort algorithm.

Tags: DIMP_1_0_RC3

Add option to IMP::addInlineScript() to indicate whether code should be
loaded onload or on DOM load.
More correct JS numeric sort algorithm.

MFH: Add "Reply To List".

Add "Reply To List" (finally).

MFH: Use (wrapped) window.onload instead of custom callbacks.

Tags: DIMP_1_0_RC2

Use (wrapped) window.onload instead of custom callbacks.

MFH: Make sure that fillForm is called after all dom:loaded handlers have been executed.

Make sure that fillForm is called after all dom:loaded handlers have been executed.

Happy New Year

Happy New Year

Be more consistent with cancel/close graphic.  I have always found it
confusing to have a cancel button w/trash icon in compose screen - a cancel
is not a delete/trash action.

Tags: FRAMEWORK_3, BEFORE_MERGE_3_2

Add 'onload' parameter to IMP::addInlineScript().

Set user agent string on outgoing messages.

Fix some more encoding issues with IE and window.open().

Tags: DIMP_1_0_RC1

Load IMP_Template library where needed

Fix variable name.

Still more prototypejs 1.6 changes.  This should be most of the rest of them.

Upgrade to Prototypejs 1.6 & scriptaculous 1.8.  Only BC-incompatible
change is to Hash objects - see http://prototypejs.org/2007/11/7/prototype-1-6-0-script-aculo-us-1-8-0-and-the-bungee-book-now-available for further
information.  I think I got most of these changes, but if something is
broken, this should probably be the first thing to look at.

Consistency with IMP - don't include text in the message body if forwarding the entire message as an rfc822 attachment.

Move all compose/fullmessage code to unique namespaces.

Initialize this earlier.

Point to new location.

add initial signature marker in DIMP. Looks like we'll need to modify the Html2Text call to be identity-aware.

simplify

Tags: DIMP_1_0_ALPHA

Better returns from replyMessage() and forwardMessage().

Bug: 5545
Use matching identity (if possible) when replying/forwarding from viewport.

Bug: 5307
Move dynamically created javascript to inline.

Need Dimple.php; clean up some once-used variables.

Only return necessary information in dimp.js.php

Correctly set Reply/Forward title when doing a fullcompose reply/forward.

Bug: 5416
Add signature in all 3 methods we use to generate compose text.

Fix displaying attachments in new composed message.

Need to move body/html closing tags back to compose.php to allow template
scripts to more easily add content to the bottom of a page.

Move compose html generation code to a function so we can more easily
call it in several places and better control and use the output.  Allows us
to better handle when javscript file/code is included in the page, cleaner
template-like files, etc.  Basically, doing the same thing we have previously
done with the ShowMessage and ListMessages code.

Use IMP's sendHTTPResponse(), which includes the null byte check/replace.

Fix removal of auto draft messages.  Also, have completely separate draft_index
value because index is used for reply/forward purposes.

So... we have to display all potential notification messages here instead since
we may not have a chance to do an AJAX call to do so later.

No need for this notify() - these notifications are caught later by the
javascript handler.

Revamp attachment code.  Essentially, the recent changes to submit compose
via AJAX calls broke attachment handling since files can only be uploaded
via submit calls.  Therefore, go the extra difference and make file uploading
an asychronous activity.  Additionally, eliminate a bunch of duplicate code
dealing with forwarded attachments - these are no different than regular
attachments and should be treated accordingly.  These changes mean we no
longer need the separate MultiFile js file to be loaded.

Correctly bring in header fields from draft message.

Move more logic out of template file and into regular compose script.

Submit compose through AJAX instead of via submit - this allows us to do
callbacks via javascript code in compose.js rather than hacking and
trying to return javascript as the page return.

Fix undefined warning once and for all.

Fix undefined variables.

Add _outputScript().
Make sure we define $base_window.

Allow stuff to work more properly when directly accessing message.php or
compose.php.
Correctly refresh folderList/messageList when in a popup of a popup (i.e.
composing a message when clicking on a compose link in a message popup).
Allow hash bookmarks to work properly in all browsers (including Safari).

Improvements to reply flagging.  Should work in all instances now.

Just too confusing having 10+ arguments.  Use an array for all optional
arguments instead.

Set answered status in message list when replying to a message.

Send folder/index/reply type information when sending message so that we
can correctly do a bunch of send-time tasks (marking message as answered,
sendmail logging, adding necessary reply headers).

tweak

Turns out we may have to include some script files after we include the
base JS files - add a parameter to DIMP::header() to allow us to do this.

Use IMP_Compose_UI:: to attach spellchecker and auto completer.

Happy New Year

Assign copyright to The Horde Project for those copyright holders that already agreed to it.

Make DimpCore.js a true static javascript file.  All PHP processing is now done
exclusively in dimp.js.php.

fix read receipts

Move this window notification/closing code into a common function.

Clean up identity handling.

$prefs is in the global scope here.

No need to pass in a separate changes list.

not implemented.

Move around some requires.

Remove some unneeded requires/reposition some requires.
Use IMP_Compose::addFilesFromUpload().

coding standards: don't use is_null().

Move all generation of responses to DIMP.
Code consolidation in several places.
Remove some unneeded requires.
Do loading of IMP's base file in dimp's base.php.

Clean up handling of saving drafts.  Instead of reference, have separate method
to retrieve UID of newly saved draft.  Don't have saveDraft() delete old
messages - looking at the old code, this was most likely broken anyway as the
indices array was not in the correct format.  Condense duplicate code in
dimp/compose.php.

condense some code

Remove all getFormData() calls from IMP_Compose::.
Code cleanup - remove a bunch of duplicate code from both imp and dimp.

Delete auto-saved drafts after a message is sent successfully.

be more consistent on how we handle imap indices in library methods