Revisions for chora/lib/base.php

constant cleanliness

Use Horde::loadConfiguration() for vhost support.

Chora::fatal() only takes one argument in FW_3.

Tags: CHORA_2_0_2

initialize() instead of init()

Move the isRestricted() check into init() for scope reasons.

ws

Registry::getParam() -> Registry::get().

Tags: FRAMEWORK_3, CHORA_2_0_1, CHORA_2_0_1_RC1, CHORA_2_0, CHORA_2_0_RC3, CHORA_2_0_RC2, CHORA_2_0_RC1, CHORA_2_0_BETA

Remove Cache initialization from VC.

No more HORDE_LIBS.

Remove includes of Browser.php that are no longer needed.

Tags: CHORA_2_0_ALPHA

Config:: and Help:: moved to framework packages.

Browser:: is now a framework package.

[cjh] Various $no_auth and $self_contained_auth flags have been standardized
into an AUTH_HANDLER constant, which if defined signals the application
that it should not check permissions upon calling $registry->pushApp(),
as the calling script will handle that itself, or is a system-level cron
job/script/etc.
[cjh] Add an option to $registry->pushApp() to specify whether or not to check
application permissions.

[cjh] The 'allow_guests' setting, and $registry->allowGuests(), have been
removed in favor of Horde_Perms application permissions.

Moved Horde_Text to framework.

[cjh] CVSLib and SVNLib are no longer part of Chora; they are part of the
new Horde VC:: package.

- lots of cleanups to use the VC:: classes or $VC methods instead of
hardcoded CVSLib references, etc.

prevent errors with transparent authentication.

Use horde/lib/core.php in all applications. For now, I've commented
out the HORDE_LIBS-based includes in core.php and we're still using
the old HORDE_BASE . '/lib/' includes everywhere. But the HORDE_LIBS
constant is now available everywhere and core.php is included to
properly set up the base framework.

I also hit a bunch of other base.php things while I was at it:

- always check the results of $registry->pushApp() and display an
error if it fails.

- removed old cache_ssl code which is handled by
Browser::downloadHeaders() now.

- make sure all base.php files check authentication (you may need to
specify allow_guests = true on some applications that were open
beforehand).

- move the auth check up as soon as possible so as not to do
unnecessary work.

- remove libraries and code that aren't used.

- try and organize files consistently.

- probably a few other minor things.

Please test out everything as you can and report problems or syntax
errors; I'm sure I missed a thing or two.

[cjh] Chora isn't just CVS now. Initial commit of Subversion support
("Jay Freeman (saurik)" <saurik@saurik.com>).

- note that a). I don't have subversion so I haven't tested this, and
b). I mucked around with a bunch of stuff to start getting rid
of CVS-specific terminology/variable names, so bits may have
broken.

[cjh] Add a new API call, Auth::isAuthenticated($realm = null), for
determining whether or not a user is logged in to the current
realm (by default null). Auth::getAuth() is still used to get
the current user, but now you don't need to know the auth realm
to get the current user - just to check authentication.

This commit replaces Auth::getAuth() with Auth::isAuthenticated()
where appropriate. Hopefully I didn't miss anywhere or cause any
problems; let me know if you find anything.

Use Browser::singleton().

[cjh] Finally get most setup code into functions in the Chora:: class.

- removed constants.php
- plenty of long-overdue cleanup
- 'login' is now a session variable so that it doesn't pollute the URL.
- UI update; no need for including version.php

Fix viral typo.

Revert the mess. I hope I got all files and correct rollback positions.

revert last commit on apps that don't have registry calls.

require_once => require on standard.php so registry calls work.

Condense some code from the applications' base.php files into standard.php.

Added Horde::authenticationFailureRedirect().

The notification backend is neither bc nor used anywhere.

Tags: CHORA_1_2_3, CHORA_1_2_2, CHORA_1_2_1, CHORA_1_2_1_RC2, CHORA_1_2_1_RC1, CHORA_1_2, CHORA_1_2_RC3, CHORA_1_2_RC2

More cleanup; remove all of the bogus echo "\n"; lines after header()
calls that at one point seemed to be needed for mobile devices, but
all of my emulators work without them now.

MFH 1.78

Tags: CHORA_1_2_RC1

Reorder loading of libraries, so that the framework (notification etc)
works if there is an error while initilizing Chora.

MFH: Move the isRestricted check and output compression into lib/base.php
from the individual files involved.

MFH:
* Add menu bar to pages as needed.
* Add preferences page.
* Added "Chora" to the menu bar.

move the isRestricted check into lib/base.php from the individual
files involved

* Add menu bar to pages as needed.
* Add preferences page.
* Added "Chora" to the menu bar, but it really should have a different
name/graphic.  Will work on this yet.

use Horde::compressOutput()

MFH:
* Use 'rb' with filesystem calls in case of windows.
* Show line numbers in the annotate view.
* Show links to view, annotate and download files in the annotate and view
  pages.
* Replace <?= with <?php echo to remove the short_open_tags requirement.
* Several bugfixes.
* Move some code from lib/base.php to lib/Chora.php.

woops, remove debug code

Clean up base.php by moving a number of things into Chora.php. lots
of cleanup can still happen here.

Next shot of superglobals patch. After MFH is completed I'll commit Horde,
IMP and Nag.

Submitted by: Nuno Loureiro <nuno@eth.pt>

MFH: lots of changes.

Tags: CHORA_1_1, CHORA_1_1_RC1

Add preferences for tracking last cvsroot and last file visited.

Submitted by: Mathieu CLABAUT <mathieu.clabaut@free.fr>

Pass $errmsg through htmlspecialchars() in fatal().

Submitted by: "Sverre H. Huseby" <shh@thathost.com>

more short-circuiting if condition

use $registry->getParam()
use CHORA_TEMPLATES

Clean up the PATH_INFO assignment logic.

implement guest controls and fix version problem

Tags: RELENG_1, CHORA_1_0, CHORA_1_0_RC1

includes are expensive - don't include version.php everywhere when we don't need it.

fix diff types when PATH_INFO isn't being used, and the ws diff stuff now
works.

Various formatting fixes (Text::htmlallspaces() calls, mainly).

Submitted by: Mathieu Arnold <arn_mat@club-internet.fr>

IMP -> Chora

IMP -> Chora

Make $conf global to include contact address to error messages.

repositories() -> Chora::repositories()

Tags: CHORA_0_6_4

Move the global url() function to Chora::url()

move lots of the global funcs in lib/base.php into the Chora
utility class.

clean them up and optimise a bit while I'm there

move some logic out of the templates into Chora::wherePath(),
and start losing some global variables from base.php

new $conf['options']['use_path_info'] option which defaults to
true (since PATH_INFO results in shorter URLs than GET propagation)

PATH_INFO is always preferred if present in a URL to preserve
existing links even if use_path_info is set to false

move away from depending on PATH_INFO for pathnames

lots of cleanup needed here (and coming soon)

add another string to gettext, and some minor spacing

Internationalise Chora via the Horde framework.

Added a sample DE locale with three words translated - can anyone
help out and submit some proper ones?

Cleanup: change all the $conf['paths'] variables to query this information
from the registry using the new API functions:

getTemplatePath(), getWebRoot(), getFileRoot(), getGraphicsPath()

Update your config files!

fix broken image tag as a result of using Horde::img()

get rid of the graphic() function, and use Chora::img() which
wraps Horde::img(), but passes it the Chora webroot queried from the registry.

convert to the new MIME_Viewer API.

Since I couldn't think of anything better, Chora overrides text/plain from
Horde, and performs URL syntax highlighting using its new local driver.

revert rev 1.45

use SCRIPT_NAME instead of PHP_SELF or else paths break

oops, this is a better solution.

fix path issue

use PHP_SELF instead of SCRIPT_NAME in all scripts/apps.

No need for Chora's mime.php anymore since we are using Horde's

Tags: CHORA_0_6_1

use Text::htmlspaces() and Text::htmlallspaces(); remove the definitions in
base.php.

use Horde::getFormData

style/require Horde.php.

Do a repository-move of common.php -> lib/base.php to be consistent
with Horde

The code in this file is still very bad, but at least it's bad code in
the right place :-)

use CHORA_BASE

start using Horde framework and fix a couple of CODING_STANDARDS things
(there are a lot of spacing issues left).

encode ampersands in urls.

fixes for problems with filenames with weird characters.

Submitted by: Mathieu Arnold <arn_mat@club-internet.fr>

style

long diff, default sort, and htmlspaces patches.

Submitted by: Mathieu Arnold <arn_mat@club-internet.fr>

fix bug with chora in webroot

Submitted by: Mathieu Arnold <arn_mat@club-internet.fr>

Dont display the exact location of the CVSROOT, if it isnt found
(agreed by bjn@ as well).  We will move towards having a test.php to
sort out these kinds of problems, and not reveal them in error messages
to end users.

Tags: CHORA_0_4_1

Display value of CVSROOT in fatal error to improve troubleshooting.

Submitted by: Pixel Date <pixeldate@hotmail.com>

add 2001 to copyright year, and other style tweaks

a few small register_globals fixes, and try to ignore all intro (non-dist)
files.

$SCRIPT_NAME -> $HTTP_SERVER_VARS['SCRIPT_NAME']

capitalization standards, lowercase package name

And fix an xhtml problem; thats the last one I can find

Tags: CHORA_0_2_0

clean up urls in page header slightly

if there is no cvsusers file, dont show the username twice in the 'fullname'
view

make the diff request forms work again

Multiple repository support, with a new config/cvsroots.php config
file.

This whole thing is real messy at the moment, especially the
dependency of CVSLib on $conf, but I'm going to clean it up all in
one go, so this commit is kind of building on the mess ;)  Primarily
so demo.horde.org can show off five or six major repositories, to help
the testing effort as well.

Add a conf[paths][cvsusers] var to control where the cvsusers file is
(not everyone keeps it in CVSROOT it seems)

Add support for parsing the cvsusers file, if present, and remove the
old method (which was to tack on a domain name at the end of the commitname)

Part of this commit snuck in with the version.php bump by mistake.

whups -> chora

Should find a new image for chora soon, but the whups one is the current
placeholder

add in the version number to the top right (probably should bump that up)

Now, this is neat ... a visual representation of the branching history
of a given repository file.

It starts off with the trunk on a single column, and then as more branches
come along, they sprout off from the tree in different colours.

The balancing algorithm for the grid can cope with an infinite number of
branch nests, so extremely complex repositories can be viewed with this
method (although it'll get pretty confusing)

Some points:

- You can view this from the 'visual branch' line in the log view,
  or the link on the top right (switch to branch view)

- The colours are temporary.  I am working on a hue/saturation -> RGB
  class, which will allow 'intelligent' use of colours for the branches.
  So that a sub-branch will be a related colour to the parent branch.
  Or perhaps high-activity branches (with lots of changed lines) will
  be stronger colours than maintainance (feature frozen) branches.

- This commit also introduces a new CVSLib_rev class, which is a
  collection of static methods to deal with cvs revisions, such as
  to validate them, and figure out root branches and so on.

- Numerous other cleanups.

Trim excessive whitespace in log messages

clean up url generation slightly by not having trailing slashes

use dirname() and basename(), instead of manually exploding/imploding

Start validation of most of our output into XHTML 1.0,
and output the relevant DOCTYPE (stolen from IMP)

fix the error pages