Revisions for chora/lib/Chora.php

missing argument to Chora::fatal()

Fix pretty urls - this whole block should have been under the check for
'rewrite', leaving the $arglist['f'] statement alone.

Add Chora::formatDate().

Whoops - didn't mean to commit this.

Revert 1.97:
http://cvs.horde.org/diff.php/chora/lib/Chora.php?r1=1.96&r2=1.97
Chuck - can you take a look at this?  When not using rewrite rules, without
the 'f' in the URL, $where in browse.php is always blank and so you can never
browse above the base level of the repository.

Put filenames in the path for any script, not just browse.php, when using rewrite rules.

Bug: 6805
Don't show log entries when there is no straight-line path between revisions.

Add Chora::getBranch(). Another place we can use Chora::getTags() also.

Add Chora::getTags().

Avoid using @ to silence define and isset errors.

Can as well label them the same.

Show either cvs graph or branch view, both are mostly the same.

wrap

Pass username/password to VC backend if present in sourceroots.php
Bug: 5958
Submitted by: duck@obala.net

[cjh] Use a dropdown list to show alternate code repositories
(greg_swift@aotx.uscourts.gov, Request #5600).

Fix forms not containing all required parameters.

Chora::fatal() only takes one argument in FW_3.

Tags: CHORA_2_0_2

Revert.  Chora::fatal() only takes one argument in FW_3.

MFH: 1.86

Fix method call.
Bug: 5020

Still show the verbose messages.

Make sure we're not trying to initialize a repository that the current user
does not have access to.  Thus, avoiding a 403 error when there are other
repositories available.

initialize() instead of init()

Move the isRestricted() check into init() for scope reasons.

- re-add ability to download diffs in various formats from the UI
- remove unneeded library functions Chora::showHiddens and Chora::differingVars

[cjh] Show commit logs when hovering on the revision number in the
annotate view (robzilla@siklos.ca, Bug #3076).

Also compress/fix a bit of HTML, and fix a bug in the annotate view
striping (it wasn't alternating every author. Not sure why we were
using modulus 3 - odd).

[cjh] Simplify codepaths by supporting only GET or mod_rewrite URLs.

Add permissions per repository.
Bug: 3186
Submitted by: ben@alkaloid.net

MFH 1.77

Add some spacing around the location links.

MFH: 1.76

Tags: CHORA_2_0_1

Reference

Bug: 2761
Submitted by: rob2 (at) siklos (dot) ca

MFH: Remove unneeded "@access public".

Tags: CHORA_2_0_1_RC1

Remove unneeded "@access public".

[mas] Change any output of <b> and <i> tags to <strong> and <em> for better
accessibility support.

Remove @version.

Remove @version.

Fix links back to the original (default) repository.

Tags: FRAMEWORK_3, CHORA_2_0, CHORA_2_0_RC3, CHORA_2_0_RC2

Use new CSS menu.

Tags: CHORA_2_0_RC1

Registry::getParam() -> Registry::get().

Tags: CHORA_2_0_BETA

Get rid off Text::toHTML().

Apps no longer need to call Help::javascript() - and indeed they shouldn't,
since it no longer exists.

Big cleanup commit.

- Try to remove the last vestiges of CVS specific-ness. cvs.php now points
to browse.php, "cvs" has been removed from UI strings, etc.

- Add mod_rewrite support for URLs so that you can have server/path/file,
with no script names in evidence anywhere, for nice and pretty URLs.

- A few fixes for SVN; with the latest VC package, I can now do at least
basic SVN repository browsing.

specify the sourceroot by its name (the key into $sourceroots) instead of by
the repo's location. this prevents the path from being exposed to outside
users, and also lets you expose parts of a large CVS repo with different
names, restrictions, etc.

Add access keys.

Use temp path as configured.

Make sure we're doing error checking on VC:: return values.

- clean up some spacing/formatting
- move readableTime() into Chora where it belongs.

Fix requiring of trailing slashes, at least for CVS (not sure how to
handle this for SVN).

No more HORDE_LIBS.

move Menu.php to a framework package.

Tags: CHORA_2_0_ALPHA

Rename CVSLIB_SORT_* and CHORA_SORT_* constants to VC_SORT_* and move the definitions to the VS package.

CVSLIB_SORT_* -> CHORA_SORT_*

Show notifications only from the requested message stack.

All footers look the same, so why not use only one.

- Move common methods to VC:: base class.
- Add dependencies to package.xml.
- Make VC classes independent from global Chora configuration.
- Some cleanup.

bunches of UI cleanup - fix broken table closing tag, etc.

Lots of SVN fixes (Jason Rust <jrust@rustyparts.com>).

* Implements the annotate feature for svn
* Implements the patchset feature for svn.  Since patchsets are native
to svn this feature is always enabled for svn repositories.  In
addition, diffing all files of a patchset is also native to svn, so a
link shows up in svn repositories to show all diffs.
* Hides the branch history link for svn repositories since you can't
determine branches from the log history.
* cvsgraph doesn't support svn so that link is not shown in svn
repositories.
* Fixed a small typo in VC.php that was killing several pages

[cjh] CVSLib and SVNLib are no longer part of Chora; they are part of the
new Horde VC:: package.

- lots of cleanups to use the VC:: classes or $VC methods instead of
hardcoded CVSLib references, etc.

Use the new Util:: class.

mfh: allow argument values of 0

Tags: CHORA_1_2_3, CHORA_1_2_2, CHORA_1_2_1, CHORA_1_2_1_RC2, CHORA_1_2_1_RC1

missed a fatal() call conversion.

- remove the id() functions; just check for PEAR_Errors.
- remove the associated constants
- minor cleanups that I hit along the way.

- nuke a bunch more references inside classes to the global $VC object
... just use the global.

- nuke the redundant *_Error classes in favor of just using PEAR Error
objects everywhere.

[cjh] Subversion repositories can now be specified as URLs, meaning non-local
repositories should work transparently

- also, a bunch of fixes for the refactoring that I did last night,
and lots of improvements in the Subversion support.

Submitted by: "Jay Freeman (saurik)" <saurik@saurik.com>

[cjh] Chora isn't just CVS now. Initial commit of Subversion support
("Jay Freeman (saurik)" <saurik@saurik.com>).

- note that a). I don't have subversion so I haven't tested this, and
b). I mucked around with a bunch of stuff to start getting rid
of CVS-specific terminology/variable names, so bits may have
broken.

phpdoc

make sure PATH_INFO is there first.

fix problem when PATH_INFO gets into PHP_SELF

Fix PATH_INFO

Submitted by: John Morrissey <jwm@horde.net>

[cjh] Add admin-defined regular expression/replacement patterns for linking
to bug-tracking or other systems.

[cjh] Add support for cvsgraph - generates graphical representations of
file histories with links to each revision and diffs between
adjacent revisions.

- generate different file view links in one place
- disable Patchsets link if cvsps isn't active

- Clean up a bunch of code, style, etc.
- Make diffs without whitespace work again
- re-use Horde calls in Chora::url() - much simpler

One more menu.php reference.

Submitted by: John Morrissey <jwm@horde.net>

More menu.php nuking

global $cvsroot, since we use it elsewhere

- minor style bits

Fix remember_last_file behavior.

[cjh] Finally get most setup code into functions in the Chora:: class.

- removed constants.php
- plenty of long-overdue cleanup
- 'login' is now a session variable so that it doesn't pollute the URL.
- UI update; no need for including version.php

Silence htmlspecialchars() call with potential unsupported charsets.

Tags: CHORA_1_2, CHORA_1_2_RC3, CHORA_1_2_RC2

REQUEST_URI and SCRIPT_NAME are not provided by all webservers. Use
PHP_SELF (in combination with QUERY_STRING if necessary) instead.

Kill trailing whitespace.

MFH: Missed 1.27

Tags: CHORA_1_2_RC1

MFH: General style cleanup, speedup optimizations.

MFH:
- have a prettier error page by using Horde::Notification
- if we get a 404/3 error, then reset the last_file preference
- check the stored CVSROOT in prefs and make sure it exists before
  using it

MFH: Style

MFH 1.29

Make sure that session field is generated in forms.

MFH 1.24: SCRIPT_NAME -> REQUEST_URI.

Add Chora::toHTML() (simplified Text::toHTML()).
MFH: Fix linebreaks in log messages. Make mailto: links work.

Tabs -> Spaces
Fix parse error in VFS/sql_file.php
Spacing of commas in function calls.

- a bit of style cleanup (still a ton to do here)
- fix a typo that meant the Attic was _always_ parsed in directory views
- add much more, and much smarter, caching of cvs file objects.

- have a prettier error page by using Horde::Notification
- if we get a 404/3 error, then reset the last_file preference
- check the stored CVSROOT in prefs and make sure it exists before
  using it

Submitted by: Akom <lists@akom2.2y.net>

Make image diffs work with PATH_INFO off.

A few more SCRIPT_NAME -> REQUEST_URI.

Fix linebreaks in log messages.

MFH:
* Use 'rb' with filesystem calls in case of windows.
* Show line numbers in the annotate view.
* Show links to view, annotate and download files in the annotate and view
  pages.
* Replace <?= with <?php echo to remove the short_open_tags requirement.
* Several bugfixes.
* Move some code from lib/base.php to lib/Chora.php.

Clean up base.php by moving a number of things into Chora.php. lots
of cleanup can still happen here.

Next shot of superglobals patch. After MFH is completed I'll commit Horde,
IMP and Nag.

Submitted by: Nuno Loureiro <nuno@eth.pt>

MFH: lots of changes.

Tags: CHORA_1_1, CHORA_1_1_RC1

Make Chora work with disabled cookies and guests not allowed.

mfh: avoid a cross-scripting vulnerability

Tags: CHORA_1_0