Revisions for agora/lib/base.php

- Do not silence define().
- Get the cache prefix entry only once

Happy New Year

[cjh] Merge Horde_Template_Compiling to stable Agora branch as Agora_Template.

Rest of the fixes for improper Horde_Loader usage.
Fairly certain this is all of them for Agora.
Duck, there are still loads of them in the incubator apps.

Move getForumId() into subclass to avoid scope check when we already know it.
As having autoload loaded, use it.

this code should be using autoloading if it's going to use Horde_View, etc.

Replace Horde_Template with Horde_View

Replace deprecated is_a with instanceof

Remove agora_template and use the new template code from framework directly.
Show use enum type if adding a moderator and the forums list is not too long.

Tags: FRAMEWORK_3

Happy New Year

Assign copyright to The Horde Project for those copyright holders that already agreed to it.

Standardize copyright wrapping and spacing.

Agora is a big loop. So use the new template code like in gollem, imp etc.

Merged Agora_Forums to agora_Mesasges. For all my test seems to work even with comments in turba.

Move all forums sorting to sql.

Get all last messages in one SQL query instead of each counting.

Clean the mess with naming message_author/message_from. Now every where use message_author like is named the SQL column.

Search is performed by only one query. Instead of performing a query pear each search. I must still implement pagination and result sorting.

DataTree is not used anymore here

Happy new year\!

ws

Happy New Year

Use the <ul> menu.

Registry::getParam() -> Registry::get().

Don't need this call here.

No more HORDE_LIBS.

Remove includes of Browser.php that are no longer needed.

Config:: and Help:: moved to framework packages.

Browser:: is now a framework package.

move Menu.php to a framework package.

[cjh] Various $no_auth and $self_contained_auth flags have been standardized
into an AUTH_HANDLER constant, which if defined signals the application
that it should not check permissions upon calling $registry->pushApp(),
as the calling script will handle that itself, or is a system-level cron
job/script/etc.
[cjh] Add an option to $registry->pushApp() to specify whether or not to check
application permissions.

[cjh] The 'allow_guests' setting, and $registry->allowGuests(), have been
removed in favor of Horde_Perms application permissions.

Instantiate a global  object in core.php.

Move Horde_Perms to framework.

- Move Category into the framework.
- At the same time, rename the API to DataTree.
- shorten some method names while we're at it.

Happy new year everyone.

Use new framework paths (Robert Clemens).

prevent errors with transparent authentication.

Use horde/lib/core.php in all applications. For now, I've commented
out the HORDE_LIBS-based includes in core.php and we're still using
the old HORDE_BASE . '/lib/' includes everywhere. But the HORDE_LIBS
constant is now available everywhere and core.php is included to
properly set up the base framework.

I also hit a bunch of other base.php things while I was at it:

- always check the results of $registry->pushApp() and display an
error if it fails.

- removed old cache_ssl code which is handled by
Browser::downloadHeaders() now.

- make sure all base.php files check authentication (you may need to
specify allow_guests = true on some applications that were open
beforehand).

- move the auth check up as soon as possible so as not to do
unnecessary work.

- remove libraries and code that aren't used.

- try and organize files consistently.

- probably a few other minor things.

Please test out everything as you can and report problems or syntax
errors; I'm sure I missed a thing or two.

get rid of the separate Menu.php lib, move a few functions over to the main Menu.php lib and the app's menu construction to the app'sgeneral lib file

don't always require the Horde_Form libs, only in the scripts where they are needed.

file comment headers

- add message deletion by admins
- clean up template objects a bit (not globaling in base.php should help)
- clean up blocks a bit

- fix threads in a horde block
- use just the regular threads.php script with a bit of a tweak

- fix blocks listing
- use Browser::singleton().

clean up, add compression

[cjh] Add a new API call, Auth::isAuthenticated($realm = null), for
determining whether or not a user is logged in to the current
realm (by default null). Auth::getAuth() is still used to get
the current user, but now you don't need to know the auth realm
to get the current user - just to check authentication.

This commit replaces Auth::getAuth() with Auth::isAuthenticated()
where appropriate. Hopefully I didn't miss anywhere or cause any
problems; let me know if you find anything.

Don't include code that isn't needed.

style, require the PEAR date class

Nuke a lot of constants.php files.

Specific Reason: constants should be defined in the application's base
class file UNLESS constants are needed in one of the configuration
files (the case for all those remaining). Only then should you break
things out to a seperate file (and even then, we may want to just
include the app's library file).

General Reason: Including files is *very* expensive. Short files are
pointless if we can avoid them; it's much cheaper to have slightly
longer files than multiple short ones (especially when we're going to
include all the short files anyways).

start tidying up, add a few more requires

typo

requires for horde_form, we don't need identities

- add some placeholder graphics
- fix some paths/links in the menu stuff
- lots and lots of style cleanup
- fix a bunch of duplicate includes/defines/other work
- don't parse templates twice
- etc.

Lots of this still seems to be missing or not to work, and the
templates are kind of a mess - can we please get all of the .dist
files out of templates/ (config/templates is fine, though).

Require the new agora menu class.

Revert the mess. I hope I got all files and correct rollback positions.

Condense some code from the applications' base.php files into standard.php.

cleaning, restructuring

cleaning up, splitting message text into a separate table

Initial revision

importing agora

Tags: start