Revisions for agora/lib/Agora.php

Happy New Year

Agora::getForumId() is not used any more

First round of reverts to fix incorrect Horde_Loader usage.

Move getForumId() into subclass to avoid scope check when we already know it.
As having autoload loaded, use it.

Some cleanups, error checking, fixes for using sqlite.

Morde scope preservation, no reason for div around pager

Check for delete permission

Happy New Year

Assign copyright to The Horde Project for those copyright holders that already agreed to it.

Standardize copyright wrapping and spacing.

Add moderator management page

Take a shot at fixing some parameter mis-matches / missing forum_id values.
Also, fix small typo. ( $message_id -> $message['message_id'] )

Merged Agora_Forums to agora_Mesasges. For all my test seems to work even with comments in turba.

Move all forums sorting to sql.

Get all last messages in one SQL query instead of each counting.

Clean the mess with naming message_author/message_from. Now every where use message_author like is named the SQL column.

Search is performed by only one query. Instead of performing a query pear each search. I must still implement pagination and result sorting.

Add a space between the sorter icon an the column name.

Change the phorm2agora script to allow different db connections and clean forum cache after migration.

BC check.

Add per scope or forum permissions

- Set default number of attachment to ?0?, to not use null and follow data logic.
- Remove forum::exits() calls from. getForumID() as an DB call already returns null if the object doesn't exists so is really not needed to access the DB twice.

"Message and flat view had nearly the same functionality. The only difference
was that the flat view shows bodies, and flat view didn't allow the to
directly post a replay. I combined the two to not have a code duplication,
and allow posting a replay directly in flat view. The thread_view_bodies
preference is extended to allow not just thread or flat view, but event flat
view with indents.

Other changes:
- Produce a query less by allowing replyMessage() to accept an message array
already retrieved in thread view.
- add pager in thread view
- add pref option to sort threads by number of posts
- allow to post a message directly even from flat view
- Fix sql syntax in agora_forum::search()
- Fix page titles in message view
- Don't even load identities if avantars are disabled in message view"
Submitted by: Duck <duck@obala.net>

[cjh] Migrate from DataTree to local SQL usage (Duck <duck@obala.net>).

Lots of fixes to make managing application comments working again. This whole app needs to be cleaned up one day.

Make sure CAPTCHA text changes on each page load.

Happy new year\!

access keys

Short circuit out of validateAvatar() if avatars are disabled.
Bug: Duck <duck@obala.net>

Remove redundant "@access" in phpdoc.

Left align column headers.

Implement agora search.

Fix viral method name typo.

use <small> instead of inline style

"- html clean up
- Agora_Forums::getForms() now don't count the messages in the messages
on-the-fly but uses its own message_seq which was alredy updated after
Agora_Messages::saveMessage().
- fixed a bug in updating thread message count (was always 1)
- adds the post form direct from the thread view. So the user is not forced to
click to post a message but can directly post a message while reading. As is
done in other forums apps.
- the form list is changed to be more compact (less colls, maybe phorum like)
- the thread template is changed to render the bodies in a separete row. So
long messages are displayed screen wide"

Submitted by: duck@obala.net

[cjh] Add avatar support (Andrew Hosie <ahosie@gmail.com>).

A few pieces still to come after some discussion.

don't highlight New Forum when editing an existing forum.

Some tweaks and UI improvements. The IE thread problems are really bizarre; they occur at random window sizes - i.e., 300px wide might work fine, but 305 doesn't. I can make it occur or not occur at a given width by adding left/right padding to the thread view. There must be a rounding error somewhere (in IE, not our code) that gets triggered based on window width.

Happy New Year

Instead of hardcoding '-1' in tons of places, use a new constant: DATATREE_ROOT. Much more readable, etc. At the same time, make this an int (-1) instead of the string value ('-1') which was inconsistent with all other datatree ids, buggy, etc.

This foreach loop was turning '-1' into -1, which meant top-level
forums couldn't be created. You have no idea how annoying this was to
track down.

Use the <ul> menu.

Change all references to *.gif images to the new *.png.

Add VFS_AGORA_PATH constant.
Add GPL information to view.php.

Registry::getParam() -> Registry::get().

change getParam('graphics') to getImageDir()

add forum name column

add ability to moderate messages by admin, still working on this...

Don't highlight Forums icon if on a index.php page of a subdirectory.

Render threaded views with Horde_Tree.

Highlight menu item when accessing forum list through index.php.

- add better sorting of forum names in forum list view, either flat by specific forum name or as part of the tree
- start adding attachment handling for messages
- clean up some templates

- fix the forums/list API call.
- add the ability to specify a seperate datatree group for forums - will be useful
for tracking comments for other applications.

Fix package names.

move message editing/deleting to own directory, fix paths

Happy new year everyone.

Consistenly allow someone with 'agora:admin' permissions to administer Agora.

use different graphic for threads and forums.

Return entries for the item class of the header, too. (selected or not)

Use the new Util:: class.

correct argument order

Trap for some errors cases.

Add sorting by thread

no need for caching here too

get rid of the separate Menu.php lib, move a few functions over to the main Menu.php lib and the app's menu construction to the app'sgeneral lib file

- set the forum id in a few more places
- part of the point of this is to use shorter variables.

typo

use a agora id to codify forum and message id in a single var

add comments

move arraySort() to Horde.php

- use shorter GET variables ('f' and 'm')
- tweak a few bits of display, use reply graphic

Various cleanups; don't do inlining of forums.php inside the forums block.

maintain key-value associations

Clean up sorting, store preferences, nuke session-based sort
variables, and sort thread list in message view.

typo

sorting functions

Start cleaning up and fixing some functionality; remove unused config
settings. Hope I'm not stepping on anything here.

missing function to format a category tree

separate out the drivers from this central file and keep here only some general utility functions

ZE2 fixes.

clean up, use just block api

my mistake we use unix epoch for time stamps, revert back to strftime()

fix the threads listing to use the PEAR date class

better date formatting

Nuke a lot of constants.php files.

Specific Reason: constants should be defined in the application's base
class file UNLESS constants are needed in one of the configuration
files (the case for all those remaining). Only then should you break
things out to a seperate file (and even then, we may want to just
include the app's library file).

General Reason: Including files is *very* expensive. Short files are
pointless if we can avoid them; it's much cheaper to have slightly
longer files than multiple short ones (especially when we're going to
include all the short files anyways).

[cjh] Fix permissions checking semantics.

A filter is something that modifies or removes items from a set. This
was not a filter. Please try to name functions according to their
actions.

fix syntax of Horde::fatal() call.

small cleaning up

- Start a major rewrite of these classes
- Adapt to the new use of Horde_Form and Horde_Template
- Style rewrites, adding some extra support functions and variables

clean up the formatted forums tree that is being returned, and put in the first steps for a permissions filter

- add some placeholder graphics
- fix some paths/links in the menu stuff
- lots and lots of style cleanup
- fix a bunch of duplicate includes/defines/other work
- don't parse templates twice
- etc.

Lots of this still seems to be missing or not to work, and the
templates are kind of a mess - can we please get all of the .dist
files out of templates/ (config/templates is fine, though).

Start tracking of various ids within the class.

lots of fixes and cleans, thread view within a message works (changed the table column type) expanded the variables in the forums and messagelist templates, counts the number of posts in a forum and shows the last message submitted to a forum

Start cleaning up, removing unused files; remove references to fields
in SQL that aren't there, fix javascript errors (calling functions
that aren't there), etc.

I now seem to have some basic functionality. Marko, do you have a set
of more useful templates available? The default ones seem to have
everything there, but are *really* sparse; it'd be nice to have a
default set of graphics, a Horde-like layout, etc.

shifted structure around, added moderated fields/functions

more cleaning, reverting back to storing message thread root in agora_messages

some cleans, changing the way message_id is used

some shuffling around of agora, still a bit broken

clean up the conf.xml

cleaning, restructuring

all in arrays

Agora.php fixed

alright, this *was* cleaned up. now it's a mess again.

fixing Agora.php

stab at CODING_STANDARDS cleanup

Fix missing &.

clean up a bit the config of backends